[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v1 for-2.12 09/15] s390x/tcg: use program_interr
From: |
David Hildenbrand |
Subject: |
Re: [qemu-s390x] [PATCH v1 for-2.12 09/15] s390x/tcg: use program_interrupt_ra() in SCLP Service Call |
Date: |
Wed, 29 Nov 2017 20:01:52 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 29.11.2017 19:10, Richard Henderson wrote:
> On 11/28/2017 08:33 PM, David Hildenbrand wrote:
>> qemu_mutex_lock_iothread();
>> int r = sclp_service_call(env, r1, r2);
>> if (r < 0) {
>> - program_interrupt(env, -r, 4);
>> - r = 0;
>> + program_interrupt_ra(env, -r, 4, GETPC());
>> }
>> qemu_mutex_unlock_iothread();
>> return r;
>
> Incidentally, shouldn't the unlock happen before throwing the exception?
> We will unlock after a longjmp, but it does look odd to write it this way.
>
Yes, but we have that all over the place, no? The unlock here could be
moved up.
>
> r~
>
--
Thanks,
David / dhildenb
- Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, (continued)
Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, Richard Henderson, 2017/11/29
[qemu-s390x] [PATCH v1 for-2.12 05/15] s390x/pci: pass the retaddr to all PCI instructions, David Hildenbrand, 2017/11/28
[qemu-s390x] [PATCH v1 for-2.12 08/15] s390x/tcg: io instructions don't need potential_page_fault(), David Hildenbrand, 2017/11/28
[qemu-s390x] [PATCH v1 for-2.12 09/15] s390x/tcg: use program_interrupt_ra() in SCLP Service Call, David Hildenbrand, 2017/11/28
[qemu-s390x] [PATCH v1 for-2.12 10/15] s390x/tcg: use program_interrupt_ra() in DIAG, David Hildenbrand, 2017/11/28
[qemu-s390x] [PATCH v1 for-2.12 11/15] s390x/tcg: use program_interrupt_ra() in per_check_exception(), David Hildenbrand, 2017/11/28
[qemu-s390x] [PATCH v1 for-2.12 12/15] s390x/tcg: use program_interrupt_ra() in SACF, David Hildenbrand, 2017/11/28
[qemu-s390x] [PATCH v1 for-2.12 14/15] s390x/tcg: drop program_interrupt(), David Hildenbrand, 2017/11/28