[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [Qemu-devel] [PATCH 3/3] s390x: deprecate s390-squash-m

From: Eric Blake
Subject: Re: [qemu-s390x] [Qemu-devel] [PATCH 3/3] s390x: deprecate s390-squash-mcss machine prop
Date: Tue, 5 Dec 2017 08:54:15 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

On 12/05/2017 06:05 AM, Halil Pasic wrote:

> Good catch! Regarding omitting the machine name, I was surprised that
> it works, but it does. Our documentation is a bit strange on this: we
> document the machine name as non-optional:
> "-machine [type=]name[,prop=value[,...]]"
> but then use -machine prop=value in the deprecation section (that's
> with no name).

QemuOpts at their "finest".  If it sees the first hunk as a value
without an =, then that value is fed to type=name; but you are also free
to make the first hunk be an explicit name=value (whether type=name or
prop=value), at which point it is up to the backend whether type can be
omitted.  So in this case, '-machine prop=value' manages to work just
fine, and it's a question of how you would convey that information in
the --help documentation.

> Since the documentation doesn't make it clear that the property is
> existent only for the s390-ccw-virtio family of the machines I think
> being your suggestion has a lot of charm. @Connie: do you agree to
> removing the machine name (type)?
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]