[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v1 for-2.12 4/5] s390x/tcg: indicate value of TO
From: |
Thomas Huth |
Subject: |
Re: [qemu-s390x] [PATCH v1 for-2.12 4/5] s390x/tcg: indicate value of TODPR in STCKE |
Date: |
Wed, 6 Dec 2017 16:24:25 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 04.12.2017 13:55, David Hildenbrand wrote:
> We were not yet using the value of the TOD Programmable Register.
>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> target/s390x/translate.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/target/s390x/translate.c b/target/s390x/translate.c
> index 48b031894a..8da8610839 100644
> --- a/target/s390x/translate.c
> +++ b/target/s390x/translate.c
> @@ -3897,7 +3897,10 @@ static ExitStatus op_stcke(DisasContext *s, DisasOps
> *o)
> {
> TCGv_i64 c1 = tcg_temp_new_i64();
> TCGv_i64 c2 = tcg_temp_new_i64();
> + TCGv_i64 todpr = tcg_temp_new_i64();
> gen_helper_stck(c1, cpu_env);
> + /* 16 bit value store in an uint32_t (only valid bits set) */
> + tcg_gen_ld32u_i64(todpr, cpu_env, offsetof(CPUS390XState, todpr));
> /* Shift the 64-bit value into its place as a zero-extended
> 104-bit value. Note that "bit positions 64-103 are always
> non-zero so that they compare differently to STCK"; we set
> @@ -3905,11 +3908,13 @@ static ExitStatus op_stcke(DisasContext *s, DisasOps
> *o)
> tcg_gen_shli_i64(c2, c1, 56);
> tcg_gen_shri_i64(c1, c1, 8);
> tcg_gen_ori_i64(c2, c2, 0x10000);
> + tcg_gen_or_i64(c2, c2, todpr);
> tcg_gen_qemu_st64(c1, o->in2, get_mem_index(s));
> tcg_gen_addi_i64(o->in2, o->in2, 8);
> tcg_gen_qemu_st64(c2, o->in2, get_mem_index(s));
> tcg_temp_free_i64(c1);
> tcg_temp_free_i64(c2);
> + tcg_temp_free_i64(todpr);
> /* ??? We don't implement clock states. */
> gen_op_movi_cc(s, 0);
> return NO_EXIT;
>
IANATE (I am not a TCG expert), but as far as I can see, this seems to
be correct.
Reviewed-by: Thomas Huth <address@hidden>
[qemu-s390x] [PATCH v1 for-2.12 3/5] s390x/tcg: implement SET CLOCK PROGRAMMABLE FIELD, David Hildenbrand, 2017/12/04
[qemu-s390x] [PATCH v1 for-2.12 4/5] s390x/tcg: indicate value of TODPR in STCKE, David Hildenbrand, 2017/12/04
- Re: [qemu-s390x] [PATCH v1 for-2.12 4/5] s390x/tcg: indicate value of TODPR in STCKE,
Thomas Huth <=
[qemu-s390x] [PATCH v1 for-2.12 1/5] s390x/kvm: factor out build_channel_report_mcic() into cpu.h, David Hildenbrand, 2017/12/04
[qemu-s390x] [PATCH v1 for-2.12 5/5] s390x/tcg: wire up STORE CHANNEL REPORT WORD, David Hildenbrand, 2017/12/04