[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v2 for-2.12 3/5] s390x/tcg: implement SET CLOCK
From: |
David Hildenbrand |
Subject: |
Re: [qemu-s390x] [PATCH v2 for-2.12 3/5] s390x/tcg: implement SET CLOCK PROGRAMMABLE FIELD |
Date: |
Fri, 8 Dec 2017 13:44:37 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 08.12.2017 01:00, Richard Henderson wrote:
> On 12/07/2017 07:31 AM, David Hildenbrand wrote:
>> +DEF_HELPER_FLAGS_1(sckpf, TCG_CALL_NO_RWG, void, env)
> ...
>> +/* Set Tod Programmable Field */
>> +void HELPER(sckpf)(CPUS390XState *env)
>> +{
>> + uint32_t val = env->regs[0];
>> +
>> + if (val & 0xffff0000) {
>> + s390_program_interrupt(env, PGM_SPECIFICATION, 2, GETPC());
>> + }
>> + env->todpr = val;
>> +}
>
> You do read a tcg global -- regs[0]. Either pass in r0 as a parameter or use
> TCG_CALL_NO_WG.
>
>
Indeed, I finally understood what the term "global" in this context
means. (global tcg vals defined in translate.c)
> r~
>
--
Thanks,
David / dhildenb
- [qemu-s390x] [PATCH v2 for-2.12 0/5] s390x/tcg: CCW hotplug support, David Hildenbrand, 2017/12/07
- [qemu-s390x] [PATCH v2 for-2.12 2/5] s390x/tcg: fix and cleanup mcck injection, David Hildenbrand, 2017/12/07
- [qemu-s390x] [PATCH v2 for-2.12 1/5] s390x/kvm: factor out build_channel_report_mcic() into cpu.h, David Hildenbrand, 2017/12/07
- [qemu-s390x] [PATCH v2 for-2.12 5/5] s390x/tcg: wire up STORE CHANNEL REPORT WORD, David Hildenbrand, 2017/12/07
- [qemu-s390x] [PATCH v2 for-2.12 3/5] s390x/tcg: implement SET CLOCK PROGRAMMABLE FIELD, David Hildenbrand, 2017/12/07
- [qemu-s390x] [PATCH v2 for-2.12 4/5] s390x/tcg: indicate value of TODPR in STCKE, David Hildenbrand, 2017/12/07