[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PATCH v4 03/10] s390-ccw: refactor IPL structs

From: Collin L. Walling
Subject: Re: [qemu-s390x] [PATCH v4 03/10] s390-ccw: refactor IPL structs
Date: Thu, 25 Jan 2018 10:13:57 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

On 01/25/2018 06:39 AM, Thomas Huth wrote:
On 23.01.2018 19:26, Collin L. Walling wrote:
ECKD DASDs have different IPL structures for CDL and LDL
formats. The current Ipl1 and Ipl2 structs follow the CDL
format, so we prepend "EckdCdl" to them. Boot info for LDL
has been moved to a new struct: EckdLdlIpl1.

Also introduce structs for IPL stages 1 and 1b.
I'd maybe move the 1b stuff into a later patch, when you really need it.

Makes sense to me.

By the way, is there a public spec available somewhere for these ECKD
boot structures?

The zipl source code should be available if you have the time and
want to understand the nitty-gritty of how all the data gets written.


I'm also fairly confident we have a document available /somewhere/...
I'll ask around and provide something for you ASAP.

Anyway, patch looks fine to me, so:

Reviewed-by: Thomas Huth <address@hidden>

Thanks for the review!

- Collin L Walling

reply via email to

[Prev in Thread] Current Thread [Next in Thread]