[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP

From: David Hildenbrand
Subject: Re: [qemu-s390x] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support
Date: Thu, 1 Mar 2018 15:36:27 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 01.03.2018 15:12, Pierre Morel wrote:
> On 28/02/2018 12:40, Cornelia Huck wrote:
>> On Wed, 28 Feb 2018 11:26:30 +0100
>> David Hildenbrand <address@hidden> wrote:
>>> Then I request the following change in KVM:
>>> If KVM_S390_VM_CPU_FEAT_AP is enabled in KVM, ECA.28 is _always_ set
>>> (not just if an AP device is configured). This especially makes things a
>>> lot easier when it comes to handling hotplugged CPUs and avoiding race
>>> conditions when enabling these bits as mentioned in the KVM series.
>>> KVM_S390_VM_CPU_FEAT_AP == AP instructions available for the guest
>>> (don't throw an operation exception).
>>> So this feature then really is guest ABI. The instructions are
>>> available. If there is no device configured, bad luck.
>> Sounds sensible from my POV.
> I have a concern with this proposition and with the original code:

Very good, this is exactly what I talked to Conny about yesterday.

Short version: CPU model is guest ABI, everything else is configuration.

> 1) ap=on is a guest ABI feature saying to the guest you can use AP 
> instructions

Indeed, that's what belongs into the CPU model.

> 2) How we provide AP instructions to the guest can be done in three 
> different ways:
>   - SIE Interpretation
>   - interception with VFIO
>   - interception with emulation

Due to bad AP design we can't handle this like zPCI - completely in
QEMU. That's what should control it.

> 3) We implement this with a device in QEMU and a certain level kernel 
> support.
> It seems possible to set or not ECA.28 , based on the type of kernel device:
> - SIE interpretation -> MATRIX KVM device -> ECA.28
> - Interception with VFIO and virtualization -> no ECA.28
> - interception with emulation -> no ECA.28
> I understand the concern with the vCPU but I think we can handle it with 
> an indirect variable
> like:
> SIE interpretation Device + KVM_S390_VM_CPU_FEAT_AP -> set the variable  
> ap_to_be_sie_interpreted=1
> Then in vCPU initialization set ECA.28 based on this variable.

That's exactly why we have the cpu feature interface. E.g. CMMA -> if
not enabled, not interpreted by HW (however also not intercepted to user
space - no sense in doing that right now).

> I think it let us more doors open, what is your opinion?

In general, for now we don't care. The kernel is the only AP bus provider.

If KVM presents AP support -> AP feature can be enabled. And it should
always enable it.

Once we have a QEMU AP bus implementation, things get more complicated.
We could provide the AP feature also without KVM (like zPCI).

But weather or not to enable the KVM control has to be concluded from
the other configuration. Only user space can now that and has to decide
before enabling AP in KVM.

So I think for now we are fine. Later, this might be tricky to check but
not impossible.

> Regards,
> Pierre



David / dhildenb

reply via email to

[Prev in Thread] Current Thread [Next in Thread]