[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PATCH 1/1] s390x/cpumodel: fix feature groups and brea

From: David Hildenbrand
Subject: Re: [qemu-s390x] [PATCH 1/1] s390x/cpumodel: fix feature groups and breakage of MSA8
Date: Fri, 23 Mar 2018 08:42:04 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 20.03.2018 14:17, Christian Borntraeger wrote:
> David, Jason, Michael,
> the cpumodel code is somewhat fragile as we have to add maintain things
> in multiple places. I would like to have more robust code, e.g. by either
> generating more or by having build bug_ons or something like that. 
> Any idea is highly welcome.
> Christian

Yes, error prone. I was also wondering if we should explicitly address
array items when initializing - e.g. in target/s390x/cpu_features.c the
"indexed by feature number for easy lookup" part. More LOC but less
error prone.

As Mimu also suggested, if we can generate something automatically, we
should do that.



David / dhildenb

reply via email to

[Prev in Thread] Current Thread [Next in Thread]