[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [Qemu-devel] [PULL 00/42] Linux user for 2.13 patches
|
From: |
no-reply |
|
Subject: |
Re: [qemu-s390x] [Qemu-devel] [PULL 00/42] Linux user for 2.13 patches |
|
Date: |
Mon, 30 Apr 2018 02:53:49 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 00/42] Linux user for 2.13 patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/address@hidden -> patchew/address@hidden
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
e8d201b9d7 linux-user: Add ARM get_tls syscall support
fff36991c4 linux-user: move xtensa cpu loop to xtensa directory
715eff8d69 linux-user: move hppa cpu loop to hppa directory
085f6b7889 linux-user: move riscv cpu loop to riscv directory
642674846e linux-user: move tilegx cpu loop to tilegx directory
40a79fbb0e linux-user: move s390x cpu loop to s390x directory
13bd8c3081 linux-user: move alpha cpu loop to alpha directory
d27e453571 linux-user: move m68k cpu loop to m68k directory
de1e4e198b linux-user: move microblaze cpu loop to microblaze directory
6edc94bd8e linux-user: move cris cpu loop to cris directory
5a09d0be10 linux-user: move sh4 cpu loop to sh4 directory
fb23bae8fe linux-user: move openrisc cpu loop to openrisc directory
0e28504595 linux-user: move nios2 cpu loop to nios2 directory
1ca42788d4 linux-user: move mips/mips64 cpu loop to mips directory
5df6189c35 linux-user: move ppc/ppc64 cpu loop to ppc directory
f9c62efd39 linux-user: move sparc/sparc64 cpu loop to sparc directory
8652473692 linux-user: move arm cpu loop to arm directory
6a92edde2b linux-user: move aarch64 cpu loop to aarch64 directory
1fd2f6f49c linux-user: move i386/x86_64 cpu loop to i386 directory
2b9c15a3f8 linux-user: create a dummy per arch cpu_loop.c
cf8175f080 linux-user: define TARGET_ARCH_HAS_SETUP_FRAME
81c693f4e3 linux-user: move ppc/ppc64 signal.c parts to ppc directory
bd02c1b83e linux-user: move mips/mips64 signal.c parts to mips directory
45be36076f linux-user: move sparc/sparc64 signal.c parts to sparc directory
3bbc202d8a linux-user: move i386/x86_64 signal.c parts to i386 directory
a1d614b53e linux-user: move xtensa signal.c parts to xtensa directory
2ea46f4874 linux-user: move hppa signal.c parts to hppa directory
87988af5d6 linux-user: move riscv signal.c parts to riscv directory
835a931479 linux-user: move tilegx signal.c parts to tilegx directory
c61b39796b linux-user: move alpha signal.c parts to alpha directory
b053a18ac5 linux-user: move m68k signal.c parts to m68k directory
477e97e2d2 linux-user: move s390x signal.c parts to s390x directory
3636147402 linux-user: move openrisc signal.c parts to openrisc directory
c85301917c linux-user: move nios2 signal.c parts to nios2 directory
590445d3ac linux-user: move cris signal.c parts to cris directory
48394e2491 linux-user: move microblaze signal.c parts to microblaze directory
af9fd39b8a linux-user: move sh4 signal.c parts to sh4 directory
6b75852825 linux-user: move arm signal.c parts to arm directory
17f3177971 linux-user: move aarch64 signal.c parts to aarch64 directory
58300191b0 linux-user: create a dummy per arch signal.c
58ba5c5111 linux-user: Fix getdents emulation for 64 bit guest on 32 bit host
eae6494620 linux-user: set minimum uname for RISC-V
=== OUTPUT BEGIN ===
Checking PATCH 1/42: linux-user: set minimum uname for RISC-V...
Checking PATCH 2/42: linux-user: Fix getdents emulation for 64 bit guest on 32
bit host...
WARNING: architecture specific defines should be avoided
#43: FILE: linux-user/syscall.c:269:
+#if defined(__NR_getdents) && HOST_LONG_BITS >= TARGET_ABI_BITS
total: 0 errors, 1 warnings, 32 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/42: linux-user: create a dummy per arch signal.c...
Checking PATCH 4/42: linux-user: move aarch64 signal.c parts to aarch64
directory...
Checking PATCH 5/42: linux-user: move arm signal.c parts to arm directory...
ERROR: open brace '{' following struct go on the same line
#110: FILE: linux-user/arm/signal.c:102:
+struct sigframe_v1
+{
ERROR: spaces required around that '-' (ctx:VxV)
#112: FILE: linux-user/arm/signal.c:104:
+ abi_ulong extramask[TARGET_NSIG_WORDS-1];
^
ERROR: open brace '{' following struct go on the same line
#117: FILE: linux-user/arm/signal.c:109:
+struct sigframe_v2
+{
ERROR: open brace '{' following struct go on the same line
#123: FILE: linux-user/arm/signal.c:115:
+struct rt_sigframe_v1
+{
ERROR: open brace '{' following struct go on the same line
#132: FILE: linux-user/arm/signal.c:124:
+struct rt_sigframe_v2
+{
WARNING: line over 80 characters
#143: FILE: linux-user/arm/signal.c:135:
+#define SWI_SYS_SIGRETURN (0xef000000|(TARGET_NR_sigreturn +
ARM_SYSCALL_BASE))
ERROR: spaces required around that '|' (ctx:VxV)
#143: FILE: linux-user/arm/signal.c:135:
+#define SWI_SYS_SIGRETURN (0xef000000|(TARGET_NR_sigreturn +
ARM_SYSCALL_BASE))
^
WARNING: line over 80 characters
#144: FILE: linux-user/arm/signal.c:136:
+#define SWI_SYS_RT_SIGRETURN (0xef000000|(TARGET_NR_rt_sigreturn +
ARM_SYSCALL_BASE))
ERROR: spaces required around that '|' (ctx:VxV)
#144: FILE: linux-user/arm/signal.c:136:
+#define SWI_SYS_RT_SIGRETURN (0xef000000|(TARGET_NR_rt_sigreturn +
ARM_SYSCALL_BASE))
^
WARNING: line over 80 characters
#151: FILE: linux-user/arm/signal.c:143:
+#define SWI_THUMB_RT_SIGRETURN (0xdf00 << 16 | 0x2700 |
(TARGET_NR_rt_sigreturn))
ERROR: "(foo*)" should be "(foo *)"
#262: FILE: linux-user/arm/signal.c:254:
+ return (abi_ulong*)(vfpframe+1);
ERROR: spaces required around that '+' (ctx:VxV)
#262: FILE: linux-user/arm/signal.c:254:
+ return (abi_ulong*)(vfpframe+1);
^
ERROR: "(foo*)" should be "(foo *)"
#282: FILE: linux-user/arm/signal.c:274:
+ return (abi_ulong*)(iwmmxtframe+1);
ERROR: spaces required around that '+' (ctx:VxV)
#282: FILE: linux-user/arm/signal.c:274:
+ return (abi_ulong*)(iwmmxtframe+1);
^
ERROR: space required before the open parenthesis '('
#314: FILE: linux-user/arm/signal.c:306:
+ for(i = 0; i < TARGET_NSIG_WORDS; i++) {
ERROR: space required before the open parenthesis '('
#334: FILE: linux-user/arm/signal.c:326:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: space required before the open parenthesis '('
#411: FILE: linux-user/arm/signal.c:403:
+ for(i = 0; i < TARGET_NSIG_WORDS; i++) {
ERROR: space required before the open parenthesis '('
#525: FILE: linux-user/arm/signal.c:517:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: if this code is redundant consider removing it
#536: FILE: linux-user/arm/signal.c:528:
+#if 0
ERROR: braces {} are necessary for all arms of this statement
#538: FILE: linux-user/arm/signal.c:530:
+ if (ptrace_cancel_bpt(current))
[...]
ERROR: "(foo*)" should be "(foo *)"
#576: FILE: linux-user/arm/signal.c:568:
+ return (abi_ulong*)(vfpframe + 1);
ERROR: "(foo*)" should be "(foo *)"
#601: FILE: linux-user/arm/signal.c:593:
+ return (abi_ulong*)(iwmmxtframe + 1);
ERROR: braces {} are necessary for all arms of this statement
#614: FILE: linux-user/arm/signal.c:606:
+ if (restore_sigcontext(env, &uc->tuc_mcontext))
[...]
ERROR: if this code is redundant consider removing it
#638: FILE: linux-user/arm/signal.c:630:
+#if 0
ERROR: braces {} are necessary for all arms of this statement
#640: FILE: linux-user/arm/signal.c:632:
+ if (ptrace_cancel_bpt(current))
[...]
ERROR: line over 90 characters
#720: FILE: linux-user/arm/signal.c:712:
+ if (do_sigaltstack(frame_addr + offsetof(struct rt_sigframe_v1,
uc.tuc_stack), 0, get_sp_from_cpustate(env)) == -EFAULT)
ERROR: braces {} are necessary for all arms of this statement
#720: FILE: linux-user/arm/signal.c:712:
+ if (do_sigaltstack(frame_addr + offsetof(struct rt_sigframe_v1,
uc.tuc_stack), 0, get_sp_from_cpustate(env)) == -EFAULT)
[...]
ERROR: if this code is redundant consider removing it
#723: FILE: linux-user/arm/signal.c:715:
+#if 0
ERROR: braces {} are necessary for all arms of this statement
#725: FILE: linux-user/arm/signal.c:717:
+ if (ptrace_cancel_bpt(current))
[...]
total: 26 errors, 3 warnings, 1524 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/42: linux-user: move sh4 signal.c parts to sh4 directory...
ERROR: open brace '{' following struct go on the same line
#60: FILE: linux-user/sh4/signal.c:52:
+struct target_sigframe
+{
ERROR: spaces required around that '-' (ctx:VxV)
#62: FILE: linux-user/sh4/signal.c:54:
+ target_ulong extramask[TARGET_NSIG_WORDS-1];
^
ERROR: open brace '{' following struct go on the same line
#76: FILE: linux-user/sh4/signal.c:68:
+struct target_rt_sigframe
+{
ERROR: spaces required around that '|' (ctx:VxV)
#83: FILE: linux-user/sh4/signal.c:75:
+#define MOVW(n) (0x9300|((n)-2)) /* Move mem word at PC+n to R3 */
^
ERROR: spaces required around that '-' (ctx:VxV)
#83: FILE: linux-user/sh4/signal.c:75:
+#define MOVW(n) (0x9300|((n)-2)) /* Move mem word at PC+n to R3 */
^
ERROR: spaces required around that '=' (ctx:VxV)
#139: FILE: linux-user/sh4/signal.c:131:
+ for (i=0; i<16; i++) {
^
ERROR: spaces required around that '<' (ctx:VxV)
#139: FILE: linux-user/sh4/signal.c:131:
+ for (i=0; i<16; i++) {
^
ERROR: spaces required around that '=' (ctx:VxV)
#167: FILE: linux-user/sh4/signal.c:159:
+ for (i=0; i<16; i++) {
^
ERROR: spaces required around that '<' (ctx:VxV)
#167: FILE: linux-user/sh4/signal.c:159:
+ for (i=0; i<16; i++) {
^
ERROR: space required before the open parenthesis '('
#257: FILE: linux-user/sh4/signal.c:249:
+ for(i = 0; i < TARGET_NSIG_WORDS; i++) {
ERROR: space required before the open parenthesis '('
#307: FILE: linux-user/sh4/signal.c:299:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: braces {} are necessary for all arms of this statement
#311: FILE: linux-user/sh4/signal.c:303:
+ if (err)
[...]
total: 12 errors, 0 warnings, 679 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 7/42: linux-user: move microblaze signal.c parts to microblaze
directory...
ERROR: return is not a function, parentheses are not required
#149: FILE: linux-user/microblaze/signal.c:140:
+ return ((sp - frame_size) & -8UL);
ERROR: braces {} are necessary for all arms of this statement
#161: FILE: linux-user/microblaze/signal.c:152:
+ if (!lock_user_struct(VERIFY_WRITE, frame, frame_addr, 0))
[...]
ERROR: space required before the open parenthesis '('
#167: FILE: linux-user/microblaze/signal.c:158:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: spaces required around that '-' (ctx:VxV)
#177: FILE: linux-user/microblaze/signal.c:168:
+ env->regs[15] = ((unsigned long)ka->sa_restorer)-8;
^
ERROR: braces {} are necessary for all arms of this statement
#229: FILE: linux-user/microblaze/signal.c:220:
+ if (!lock_user_struct(VERIFY_WRITE, frame, frame_addr, 1))
[...]
ERROR: space required before the open parenthesis '('
#234: FILE: linux-user/microblaze/signal.c:225:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
total: 6 errors, 0 warnings, 476 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 8/42: linux-user: move cris signal.c parts to cris directory...
ERROR: braces {} are necessary for all arms of this statement
#117: FILE: linux-user/cris/signal.c:109:
+ if (!lock_user_struct(VERIFY_WRITE, frame, frame_addr, 0))
[...]
ERROR: spaces required around that '+' (ctx:VxV)
#127: FILE: linux-user/cris/signal.c:119:
+ __put_user(0x9c5f, frame->retcode+0);
^
ERROR: space required before the open parenthesis '('
#135: FILE: linux-user/cris/signal.c:127:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: space required before the open parenthesis '('
#178: FILE: linux-user/cris/signal.c:170:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
total: 4 errors, 0 warnings, 358 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 9/42: linux-user: move nios2 signal.c parts to nios2 directory...
Checking PATCH 10/42: linux-user: move openrisc signal.c parts to openrisc
directory...
ERROR: if this code is redundant consider removing it
#58: FILE: linux-user/openrisc/signal.c:49:
+#if 0
total: 1 errors, 0 warnings, 441 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 11/42: linux-user: move s390x signal.c parts to s390x
directory...
ERROR: spaces required around that '*' (ctx:VxV)
#44: FILE: linux-user/s390x/signal.c:35:
+#define _SIGMASK_COPY_SIZE (sizeof(unsigned long)*_SIGCONTEXT_NSIG_WORDS)
^
WARNING: line over 80 characters
#45: FILE: linux-user/s390x/signal.c:36:
+#define PSW_ADDR_AMODE 0x0000000000000000UL /* 0x80000000UL for
31-bit */
ERROR: do not use C99 // comments
#121: FILE: linux-user/s390x/signal.c:112:
+ //save_access_regs(current->thread.acrs); FIXME
ERROR: do not use C99 // comments
#137: FILE: linux-user/s390x/signal.c:128:
+ //save_fp_regs(¤t->thread.fp_regs); FIXME
ERROR: do not use C99 // comments
#181: FILE: linux-user/s390x/signal.c:172:
+ env->regs[2] = sig; //map_signal(sig);
ERROR: do not use C99 // comments
#186: FILE: linux-user/s390x/signal.c:177:
+ env->regs[4] = 0; // FIXME: no clue... current->thread.trap_no;
ERROR: do not use C99 // comments
#187: FILE: linux-user/s390x/signal.c:178:
+ env->regs[5] = 0; // FIXME: no clue... current->thread.prot_addr;
ERROR: do not use C99 // comments
#244: FILE: linux-user/s390x/signal.c:235:
+ env->regs[2] = sig; //map_signal(sig);
total: 7 errors, 1 warnings, 634 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 12/42: linux-user: move m68k signal.c parts to m68k directory...
ERROR: open brace '{' following struct go on the same line
#45: FILE: linux-user/m68k/signal.c:37:
+struct target_sigframe
+{
ERROR: spaces required around that '-' (ctx:VxV)
#51: FILE: linux-user/m68k/signal.c:43:
+ abi_ulong extramask[TARGET_NSIG_WORDS-1];
^
ERROR: spaces required around that '*' (ctx:VxV)
#61: FILE: linux-user/m68k/signal.c:53:
+ int f_fpregs[8*3];
^
ERROR: open brace '{' following struct go on the same line
#82: FILE: linux-user/m68k/signal.c:74:
+struct target_rt_sigframe
+{
ERROR: space prohibited between function name and open parenthesis '('
#133: FILE: linux-user/m68k/signal.c:125:
+ if ((ka->sa_flags & TARGET_SA_ONSTACK) && (sas_ss_flags (sp) == 0)) {
ERROR: return is not a function, parentheses are not required
#137: FILE: linux-user/m68k/signal.c:129:
+ return ((sp - frame_size) & -8UL);
ERROR: space required before the open parenthesis '('
#162: FILE: linux-user/m68k/signal.c:154:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: braces {} are necessary for all arms of this statement
#265: FILE: linux-user/m68k/signal.c:257:
+ if (temp != TARGET_MCONTEXT_VERSION)
[...]
ERROR: braces {} are necessary for all arms of this statement
#337: FILE: linux-user/m68k/signal.c:329:
+ if (err)
[...]
ERROR: space required before the open parenthesis '('
#340: FILE: linux-user/m68k/signal.c:332:
+ for(i = 0; i < TARGET_NSIG_WORDS; i++) {
ERROR: braces {} are necessary for all arms of this statement
#355: FILE: linux-user/m68k/signal.c:347:
+ if (err)
[...]
ERROR: braces {} are necessary for all arms of this statement
#380: FILE: linux-user/m68k/signal.c:372:
+ if (!lock_user_struct(VERIFY_READ, frame, frame_addr, 1))
[...]
ERROR: space required before the open parenthesis '('
#387: FILE: linux-user/m68k/signal.c:379:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: braces {} are necessary for all arms of this statement
#413: FILE: linux-user/m68k/signal.c:405:
+ if (!lock_user_struct(VERIFY_READ, frame, frame_addr, 1))
[...]
ERROR: braces {} are necessary for all arms of this statement
#421: FILE: linux-user/m68k/signal.c:413:
+ if (target_rt_restore_ucontext(env, &frame->uc))
[...]
total: 15 errors, 0 warnings, 836 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 13/42: linux-user: move alpha signal.c parts to alpha
directory...
Checking PATCH 14/42: linux-user: move tilegx signal.c parts to tilegx
directory...
Checking PATCH 15/42: linux-user: move riscv signal.c parts to riscv
directory...
Checking PATCH 16/42: linux-user: move hppa signal.c parts to hppa directory...
Checking PATCH 17/42: linux-user: move xtensa signal.c parts to xtensa
directory...
Checking PATCH 18/42: linux-user: move i386/x86_64 signal.c parts to i386
directory...
ERROR: spaces required around that '-' (ctx:VxV)
#177: FILE: linux-user/i386/signal.c:167:
+ abi_ulong extramask[TARGET_NSIG_WORDS-1];
^
WARNING: line over 80 characters
#304: FILE: linux-user/i386/signal.c:294:
+ esp = target_sigaltstack_used.ss_sp +
target_sigaltstack_used.ss_size;
ERROR: braces {} are necessary for all arms of this statement
#336: FILE: linux-user/i386/signal.c:326:
+ if (!lock_user_struct(VERIFY_WRITE, frame, frame_addr, 0))
[...]
ERROR: space required before the open parenthesis '('
#344: FILE: linux-user/i386/signal.c:334:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: spaces required around that '+' (ctx:VxV)
#359: FILE: linux-user/i386/signal.c:349:
+ __put_user(val16, (uint16_t *)(frame->retcode+0));
^
ERROR: spaces required around that '+' (ctx:VxV)
#360: FILE: linux-user/i386/signal.c:350:
+ __put_user(TARGET_NR_sigreturn, (int *)(frame->retcode+2));
^
ERROR: spaces required around that '+' (ctx:VxV)
#362: FILE: linux-user/i386/signal.c:352:
+ __put_user(val16, (uint16_t *)(frame->retcode+6));
^
ERROR: braces {} are necessary for all arms of this statement
#399: FILE: linux-user/i386/signal.c:389:
+ if (!lock_user_struct(VERIFY_WRITE, frame, frame_addr, 0))
[...]
ERROR: space required before the open parenthesis '('
#425: FILE: linux-user/i386/signal.c:415:
+ for(i = 0; i < TARGET_NSIG_WORDS; i++) {
ERROR: spaces required around that '+' (ctx:VxV)
#439: FILE: linux-user/i386/signal.c:429:
+ __put_user(0xb8, (char *)(frame->retcode+0));
^
ERROR: spaces required around that '+' (ctx:VxV)
#440: FILE: linux-user/i386/signal.c:430:
+ __put_user(TARGET_NR_rt_sigreturn, (int *)(frame->retcode+1));
^
ERROR: spaces required around that '+' (ctx:VxV)
#442: FILE: linux-user/i386/signal.c:432:
+ __put_user(val16, (uint16_t *)(frame->retcode+5));
^
ERROR: do not use C99 // comments
#529: FILE: linux-user/i386/signal.c:519:
+ // regs->orig_eax = -1; /* disable syscall checks */
ERROR: braces {} are necessary for all arms of this statement
#559: FILE: linux-user/i386/signal.c:549:
+ if (!lock_user_struct(VERIFY_READ, frame, frame_addr, 1))
[...]
ERROR: space required before the open parenthesis '('
#563: FILE: linux-user/i386/signal.c:553:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: braces {} are necessary for all arms of this statement
#571: FILE: linux-user/i386/signal.c:561:
+ if (restore_sigcontext(env, &frame->sc))
[...]
ERROR: braces {} are necessary for all arms of this statement
#591: FILE: linux-user/i386/signal.c:581:
+ if (!lock_user_struct(VERIFY_READ, frame, frame_addr, 1))
[...]
WARNING: line over 80 characters
#600: FILE: linux-user/i386/signal.c:590:
+ if (do_sigaltstack(frame_addr + offsetof(struct rt_sigframe,
uc.tuc_stack), 0,
total: 16 errors, 2 warnings, 1196 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 19/42: linux-user: move sparc/sparc64 signal.c parts to sparc
directory...
ERROR: space prohibited before open square bracket '['
#709: FILE: linux-user/sparc/signal.c:83:
+ } si_fpqueue [16];
ERROR: space prohibited between function name and open parenthesis '('
#717: FILE: linux-user/sparc/signal.c:91:
+ abi_ulong insns[2] __attribute__ ((aligned (8)));
ERROR: trailing whitespace
#748: FILE: linux-user/sparc/signal.c:122:
+static inline abi_ulong get_sigframe(struct target_sigaction *sa, $
ERROR: line over 90 characters
#759: FILE: linux-user/sparc/signal.c:133:
+ && !((target_sigaltstack_used.ss_sp +
target_sigaltstack_used.ss_size) & 7)) {
WARNING: line over 80 characters
#760: FILE: linux-user/sparc/signal.c:134:
+ sp = target_sigaltstack_used.ss_sp +
target_sigaltstack_used.ss_size;
ERROR: spaces required around that '=' (ctx:VxV)
#775: FILE: linux-user/sparc/signal.c:149:
+ for (i=0; i < 8; i++) {
^
ERROR: spaces required around that '=' (ctx:VxV)
#778: FILE: linux-user/sparc/signal.c:152:
+ for (i=0; i < 8; i++) {
^
ERROR: spaces required around that '+' (ctx:VxV)
#779: FILE: linux-user/sparc/signal.c:153:
+ __put_user(env->regwptr[UREG_I0 + i], &si->si_regs.u_regs[i+8]);
^
ERROR: if this code is redundant consider removing it
#785: FILE: linux-user/sparc/signal.c:159:
+#if 0
ERROR: do not use C99 // comments
#813: FILE: linux-user/sparc/signal.c:187:
+ //synchronize_user_stack();
ERROR: if this code is redundant consider removing it
#824: FILE: linux-user/sparc/signal.c:198:
+#if 0
ERROR: braces {} are necessary for all arms of this statement
#825: FILE: linux-user/sparc/signal.c:199:
+ if (invalid_frame_pointer(sf, sigframe_size))
[...]
ERROR: do not use C99 // comments
#832: FILE: linux-user/sparc/signal.c:206:
+ //save_fpu_state(regs, &sf->fpu_state);
ERROR: do not use C99 // comments
#833: FILE: linux-user/sparc/signal.c:207:
+ //__put_user(&sf->fpu_state, &sf->fpu_save);
ERROR: braces {} are necessary for all arms of this statement
#846: FILE: linux-user/sparc/signal.c:220:
+ if (err)
[...]
ERROR: braces {} are necessary for all arms of this statement
#876: FILE: linux-user/sparc/signal.c:250:
+ if (err)
[...]
ERROR: do not use C99 // comments
#880: FILE: linux-user/sparc/signal.c:254:
+ // flush_sig_insns(current->mm, (unsigned long) &(sf->insns[0]));
ERROR: do not use C99 // comments
#881: FILE: linux-user/sparc/signal.c:255:
+ // tb_flush(env);
ERROR: if this code is redundant consider removing it
#885: FILE: linux-user/sparc/signal.c:259:
+#if 0
ERROR: spaces required around that '=' (ctx:VxV)
#908: FILE: linux-user/sparc/signal.c:282:
+ int err=0, i;
^
ERROR: braces {} are necessary for all arms of this statement
#918: FILE: linux-user/sparc/signal.c:292:
+ if (sf_addr & 3)
[...]
ERROR: spaces required around that '=' (ctx:VxV)
#938: FILE: linux-user/sparc/signal.c:312:
+ for (i=0; i < 8; i++) {
^
ERROR: spaces required around that '=' (ctx:VxV)
#941: FILE: linux-user/sparc/signal.c:315:
+ for (i=0; i < 8; i++) {
^
ERROR: spaces required around that '+' (ctx:VxV)
#942: FILE: linux-user/sparc/signal.c:316:
+ __get_user(env->regwptr[i + UREG_I0], &sf->info.si_regs.u_regs[i+8]);
^
ERROR: space required before the open parenthesis '('
#955: FILE: linux-user/sparc/signal.c:329:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: do not use C99 // comments
#1015: FILE: linux-user/sparc/signal.c:389:
+ //uint128_t qregs[16];
ERROR: spaces required around that '+' (ctx:VxV)
#1112: FILE: linux-user/sparc/signal.c:486:
+ w_addr = TARGET_STACK_BIAS+env->regwptr[UREG_I6];
^
ERROR: spaces required around that '/' (ctx:VxV)
#1131: FILE: linux-user/sparc/signal.c:505:
+ __get_user(env->fpr[i/2].l.lower, src);
^
ERROR: spaces required around that '/' (ctx:VxV)
#1133: FILE: linux-user/sparc/signal.c:507:
+ __get_user(env->fpr[i/2].l.upper, src);
^
ERROR: trailing whitespace
#1164: FILE: linux-user/sparc/signal.c:538:
+ $
ERROR: braces {} are necessary for all arms of this statement
#1190: FILE: linux-user/sparc/signal.c:564:
+ if (err)
[...]
ERROR: do not use C99 // comments
#1195: FILE: linux-user/sparc/signal.c:569:
+ // __put_user(env->tstate, &((*grp)[SPARC_MC_TSTATE]));
ERROR: spaces required around that '+' (ctx:VxV)
#1215: FILE: linux-user/sparc/signal.c:589:
+ w_addr = TARGET_STACK_BIAS+env->regwptr[UREG_I6];
^
ERROR: spaces required around that '/' (ctx:VxV)
#1232: FILE: linux-user/sparc/signal.c:606:
+ __put_user(env->fpr[i/2].l.lower, dst);
^
ERROR: spaces required around that '/' (ctx:VxV)
#1234: FILE: linux-user/sparc/signal.c:608:
+ __put_user(env->fpr[i/2].l.upper, dst);
^
ERROR: braces {} are necessary for all arms of this statement
#1242: FILE: linux-user/sparc/signal.c:616:
+ if (err)
[...]
total: 35 errors, 1 warnings, 1244 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 20/42: linux-user: move mips/mips64 signal.c parts to mips
directory...
ERROR: space prohibited between function name and open parenthesis '('
#204: FILE: linux-user/mips/signal.c:193:
+ if ((ka->sa_flags & TARGET_SA_ONSTACK) && (sas_ss_flags (sp) == 0)) {
ERROR: "foo * bar" should be "foo *bar"
#222: FILE: linux-user/mips/signal.c:211:
+void setup_frame(int sig, struct target_sigaction * ka,
ERROR: space required before the open parenthesis '('
#239: FILE: linux-user/mips/signal.c:228:
+ for(i = 0; i < TARGET_NSIG_WORDS; i++) {
ERROR: space prohibited after that open square bracket '['
#253: FILE: linux-user/mips/signal.c:242:
+ regs->active_tc.gpr[ 4] = sig;
ERROR: space prohibited after that open square bracket '['
#254: FILE: linux-user/mips/signal.c:243:
+ regs->active_tc.gpr[ 5] = 0;
ERROR: space prohibited after that open square bracket '['
#255: FILE: linux-user/mips/signal.c:244:
+ regs->active_tc.gpr[ 6] = frame_addr + offsetof(struct sigframe, sf_sc);
ERROR: braces {} are necessary for all arms of this statement
#280: FILE: linux-user/mips/signal.c:269:
+ if (!lock_user_struct(VERIFY_READ, frame, frame_addr, 1))
[...]
ERROR: space required before the open parenthesis '('
#283: FILE: linux-user/mips/signal.c:272:
+ for(i = 0; i < TARGET_NSIG_WORDS; i++) {
ERROR: if this code is redundant consider removing it
#292: FILE: linux-user/mips/signal.c:281:
+#if 0
ERROR: spaces required around that ':' (ctx:ExV)
#300: FILE: linux-user/mips/signal.c:289:
+ :"r" (®s));
^
WARNING: line over 80 characters
#338: FILE: linux-user/mips/signal.c:327:
+ __put_user(target_sigaltstack_used.ss_size,
&frame->rs_uc.tuc_stack.ss_size);
ERROR: space required before the open parenthesis '('
#344: FILE: linux-user/mips/signal.c:333:
+ for(i = 0; i < TARGET_NSIG_WORDS; i++) {
ERROR: space prohibited after that open square bracket '['
#358: FILE: linux-user/mips/signal.c:347:
+ env->active_tc.gpr[ 4] = sig;
ERROR: space prohibited after that open square bracket '['
#359: FILE: linux-user/mips/signal.c:348:
+ env->active_tc.gpr[ 5] = frame_addr
ERROR: space prohibited after that open square bracket '['
#361: FILE: linux-user/mips/signal.c:350:
+ env->active_tc.gpr[ 6] = frame_addr
ERROR: "foo * bar" should be "foo *bar"
#423: FILE: linux-user/mips/target_signal.h:31:
+void setup_frame(int sig, struct target_sigaction * ka,
total: 15 errors, 1 warnings, 798 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 21/42: linux-user: move ppc/ppc64 signal.c parts to ppc
directory...
ERROR: braces {} are necessary for all arms of this statement
#376: FILE: linux-user/ppc/signal.c:368:
+ if (sig)
[...]
ERROR: braces {} are necessary for all arms of this statement
#455: FILE: linux-user/ppc/signal.c:447:
+ if (!lock_user_struct(VERIFY_WRITE, frame, frame_addr, 1))
[...]
ERROR: braces {} are necessary for all arms of this statement
#482: FILE: linux-user/ppc/signal.c:474:
+ if (err)
[...]
ERROR: braces {} are necessary for all arms of this statement
#519: FILE: linux-user/ppc/signal.c:511:
+ if (!lock_user_struct(VERIFY_WRITE, rt_sf, rt_sf_addr, 1))
[...]
ERROR: space prohibited between function name and open parenthesis '('
#533: FILE: linux-user/ppc/signal.c:525:
+ __put_user(h2g (&rt_sf->uc.tuc_mcontext),
ERROR: space required before the open parenthesis '('
#536: FILE: linux-user/ppc/signal.c:528:
+ for(i = 0; i < TARGET_NSIG_WORDS; i++) {
ERROR: braces {} are necessary for all arms of this statement
#566: FILE: linux-user/ppc/signal.c:558:
+ if (err)
[...]
ERROR: braces {} are necessary for all arms of this statement
#615: FILE: linux-user/ppc/signal.c:607:
+ if (!lock_user_struct(VERIFY_READ, sc, sc_addr, 1))
[...]
ERROR: braces {} are necessary for all arms of this statement
#628: FILE: linux-user/ppc/signal.c:620:
+ if (!lock_user_struct(VERIFY_READ, sr, sr_addr, 1))
[...]
WARNING: line over 80 characters
#652: FILE: linux-user/ppc/signal.c:644:
+ if (copy_from_user(&set, h2g(ucp) + offsetof(struct target_ucontext,
tuc_sigmask),
ERROR: space prohibited between function name and open parenthesis '('
#653: FILE: linux-user/ppc/signal.c:645:
+ sizeof (set)))
ERROR: braces {} are necessary for all arms of this statement
#663: FILE: linux-user/ppc/signal.c:655:
+ if (!lock_user_struct(VERIFY_READ, mcp, mcp_addr, 1))
[...]
ERROR: braces {} are necessary for all arms of this statement
#680: FILE: linux-user/ppc/signal.c:672:
+ if (!lock_user_struct(VERIFY_READ, rt_sf, rt_sf_addr, 1))
[...]
ERROR: braces {} are necessary for all arms of this statement
#683: FILE: linux-user/ppc/signal.c:675:
+ if (do_setcontext(&rt_sf->uc, env, 1))
[...]
total: 13 errors, 1 warnings, 1361 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 22/42: linux-user: define TARGET_ARCH_HAS_SETUP_FRAME...
Checking PATCH 23/42: linux-user: create a dummy per arch cpu_loop.c...
Checking PATCH 24/42: linux-user: move i386/x86_64 cpu loop to i386 directory...
ERROR: space required before the open parenthesis '('
#92: FILE: linux-user/i386/cpu_loop.c:91:
+ for(;;) {
ERROR: space required before the open parenthesis '('
#98: FILE: linux-user/i386/cpu_loop.c:97:
+ switch(trapnr) {
ERROR: braces {} are necessary for all arms of this statement
#161: FILE: linux-user/i386/cpu_loop.c:160:
+ if (!(env->error_code & 1))
[...]
+ else
[...]
ERROR: that open brace { should be on the previous line
#233: FILE: linux-user/i386/cpu_loop.c:232:
+ if (sig)
+ {
WARNING: line over 80 characters
#247: FILE: linux-user/i386/cpu_loop.c:246:
+ EXCP_DUMP(env, "qemu: 0x%08lx: unhandled CPU exception 0x%x -
aborting\n",
ERROR: spaces required around that '|' (ctx:VxV)
#307: FILE: linux-user/i386/cpu_loop.c:306:
+ PROT_READ|PROT_WRITE,
^
ERROR: spaces required around that '|' (ctx:VxV)
#308: FILE: linux-user/i386/cpu_loop.c:307:
+ MAP_ANONYMOUS|MAP_PRIVATE, -1, 0);
^
ERROR: spaces required around that '|' (ctx:VxV)
#336: FILE: linux-user/i386/cpu_loop.c:335:
+ PROT_READ|PROT_WRITE,
^
ERROR: spaces required around that '|' (ctx:VxV)
#337: FILE: linux-user/i386/cpu_loop.c:336:
+ MAP_ANONYMOUS|MAP_PRIVATE, -1, 0);
^
total: 8 errors, 1 warnings, 720 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 25/42: linux-user: move aarch64 cpu loop to aarch64 directory...
WARNING: line over 80 characters
#141: FILE: linux-user/aarch64/cpu_loop.c:142:
+ EXCP_DUMP(env, "qemu: unhandled CPU exception 0x%x - aborting\n",
trapnr);
total: 0 errors, 1 warnings, 289 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 26/42: linux-user: move arm cpu loop to arm directory...
ERROR: braces {} are necessary for all arms of this statement
#172: FILE: linux-user/arm/cpu_loop.c:171:
+ if (get_user_u32(val, addr))
[...]
ERROR: space required before the open parenthesis '('
#217: FILE: linux-user/arm/cpu_loop.c:216:
+ for(;;) {
ERROR: space required before the open parenthesis '('
#223: FILE: linux-user/arm/cpu_loop.c:222:
+ switch(trapnr) {
ERROR: spaces required around that '=' (ctx:VxV)
#245: FILE: linux-user/arm/cpu_loop.c:244:
+ int arm_fpe=0;
^
ERROR: suspect code indent for conditional statements (20, 22)
#248: FILE: linux-user/arm/cpu_loop.c:247:
+ if (-rc & float_flag_invalid)
+ arm_fpe |= BIT_IOC;
ERROR: braces {} are necessary for all arms of this statement
#248: FILE: linux-user/arm/cpu_loop.c:247:
+ if (-rc & float_flag_invalid)
[...]
ERROR: suspect code indent for conditional statements (20, 22)
#250: FILE: linux-user/arm/cpu_loop.c:249:
+ if (-rc & float_flag_divbyzero)
+ arm_fpe |= BIT_DZC;
ERROR: braces {} are necessary for all arms of this statement
#250: FILE: linux-user/arm/cpu_loop.c:249:
+ if (-rc & float_flag_divbyzero)
[...]
ERROR: suspect code indent for conditional statements (20, 22)
#252: FILE: linux-user/arm/cpu_loop.c:251:
+ if (-rc & float_flag_overflow)
+ arm_fpe |= BIT_OFC;
ERROR: braces {} are necessary for all arms of this statement
#252: FILE: linux-user/arm/cpu_loop.c:251:
+ if (-rc & float_flag_overflow)
[...]
ERROR: suspect code indent for conditional statements (20, 22)
#254: FILE: linux-user/arm/cpu_loop.c:253:
+ if (-rc & float_flag_underflow)
+ arm_fpe |= BIT_UFC;
ERROR: braces {} are necessary for all arms of this statement
#254: FILE: linux-user/arm/cpu_loop.c:253:
+ if (-rc & float_flag_underflow)
[...]
ERROR: suspect code indent for conditional statements (20, 22)
#256: FILE: linux-user/arm/cpu_loop.c:255:
+ if (-rc & float_flag_inexact)
+ arm_fpe |= BIT_IXC;
ERROR: braces {} are necessary for all arms of this statement
#256: FILE: linux-user/arm/cpu_loop.c:255:
+ if (-rc & float_flag_inexact)
[...]
ERROR: do not use C99 // comments
#260: FILE: linux-user/arm/cpu_loop.c:259:
+ //printf("fpsr 0x%x, arm_fpe 0x%x\n",fpsr,arm_fpe);
ERROR: trailing statements should be on next line
#267: FILE: linux-user/arm/cpu_loop.c:266:
+ if (arm_fpe & BIT_IXC) info.si_code = TARGET_FPE_FLTRES;
ERROR: braces {} are necessary for all arms of this statement
#267: FILE: linux-user/arm/cpu_loop.c:266:
+ if (arm_fpe & BIT_IXC) info.si_code = TARGET_FPE_FLTRES;
[...]
ERROR: trailing statements should be on next line
#268: FILE: linux-user/arm/cpu_loop.c:267:
+ if (arm_fpe & BIT_UFC) info.si_code = TARGET_FPE_FLTUND;
ERROR: braces {} are necessary for all arms of this statement
#268: FILE: linux-user/arm/cpu_loop.c:267:
+ if (arm_fpe & BIT_UFC) info.si_code = TARGET_FPE_FLTUND;
[...]
ERROR: trailing statements should be on next line
#269: FILE: linux-user/arm/cpu_loop.c:268:
+ if (arm_fpe & BIT_OFC) info.si_code = TARGET_FPE_FLTOVF;
ERROR: braces {} are necessary for all arms of this statement
#269: FILE: linux-user/arm/cpu_loop.c:268:
+ if (arm_fpe & BIT_OFC) info.si_code = TARGET_FPE_FLTOVF;
[...]
ERROR: trailing statements should be on next line
#270: FILE: linux-user/arm/cpu_loop.c:269:
+ if (arm_fpe & BIT_DZC) info.si_code = TARGET_FPE_FLTDIV;
ERROR: braces {} are necessary for all arms of this statement
#270: FILE: linux-user/arm/cpu_loop.c:269:
+ if (arm_fpe & BIT_DZC) info.si_code = TARGET_FPE_FLTDIV;
[...]
ERROR: trailing statements should be on next line
#271: FILE: linux-user/arm/cpu_loop.c:270:
+ if (arm_fpe & BIT_IOC) info.si_code = TARGET_FPE_FLTINV;
ERROR: braces {} are necessary for all arms of this statement
#271: FILE: linux-user/arm/cpu_loop.c:270:
+ if (arm_fpe & BIT_IOC) info.si_code = TARGET_FPE_FLTINV;
[...]
ERROR: suspect code indent for conditional statements (20, 22)
#280: FILE: linux-user/arm/cpu_loop.c:279:
+ if ((!(fpsr & BIT_IXE)) && (arm_fpe & BIT_IXC))
+ fpsr |= BIT_IXC;
ERROR: braces {} are necessary for all arms of this statement
#280: FILE: linux-user/arm/cpu_loop.c:279:
+ if ((!(fpsr & BIT_IXE)) && (arm_fpe & BIT_IXC))
[...]
ERROR: suspect code indent for conditional statements (20, 22)
#282: FILE: linux-user/arm/cpu_loop.c:281:
+ if ((!(fpsr & BIT_UFE)) && (arm_fpe & BIT_UFC))
+ fpsr |= BIT_UFC;
ERROR: braces {} are necessary for all arms of this statement
#282: FILE: linux-user/arm/cpu_loop.c:281:
+ if ((!(fpsr & BIT_UFE)) && (arm_fpe & BIT_UFC))
[...]
ERROR: suspect code indent for conditional statements (20, 22)
#284: FILE: linux-user/arm/cpu_loop.c:283:
+ if ((!(fpsr & BIT_OFE)) && (arm_fpe & BIT_OFC))
+ fpsr |= BIT_OFC;
ERROR: braces {} are necessary for all arms of this statement
#284: FILE: linux-user/arm/cpu_loop.c:283:
+ if ((!(fpsr & BIT_OFE)) && (arm_fpe & BIT_OFC))
[...]
ERROR: suspect code indent for conditional statements (20, 22)
#286: FILE: linux-user/arm/cpu_loop.c:285:
+ if ((!(fpsr & BIT_DZE)) && (arm_fpe & BIT_DZC))
+ fpsr |= BIT_DZC;
ERROR: braces {} are necessary for all arms of this statement
#286: FILE: linux-user/arm/cpu_loop.c:285:
+ if ((!(fpsr & BIT_DZE)) && (arm_fpe & BIT_DZC))
[...]
ERROR: suspect code indent for conditional statements (20, 22)
#288: FILE: linux-user/arm/cpu_loop.c:287:
+ if ((!(fpsr & BIT_IOE)) && (arm_fpe & BIT_IOC))
+ fpsr |= BIT_IOC;
ERROR: braces {} are necessary for all arms of this statement
#288: FILE: linux-user/arm/cpu_loop.c:287:
+ if ((!(fpsr & BIT_IOE)) && (arm_fpe & BIT_IOC))
[...]
ERROR: spaces required around that '=' (ctx:VxV)
#290: FILE: linux-user/arm/cpu_loop.c:289:
+ ts->fpa.fpsr=fpsr;
^
ERROR: space prohibited between function name and open parenthesis '('
#330: FILE: linux-user/arm/cpu_loop.c:329:
+ env->regs[0] = do_arm_semihosting (env);
ERROR: space prohibited after that open parenthesis '('
#339: FILE: linux-user/arm/cpu_loop.c:338:
+ if ( n > ARM_NR_BASE) {
ERROR: that open brace { should be on the previous line
#402: FILE: linux-user/arm/cpu_loop.c:401:
+ if (sig)
+ {
ERROR: suspect code indent for conditional statements (12, 14)
#412: FILE: linux-user/arm/cpu_loop.c:411:
+ if (do_kernel_trap(env))
+ goto error;
ERROR: braces {} are necessary for all arms of this statement
#412: FILE: linux-user/arm/cpu_loop.c:411:
+ if (do_kernel_trap(env))
[...]
WARNING: line over 80 characters
#423: FILE: linux-user/arm/cpu_loop.c:422:
+ EXCP_DUMP(env, "qemu: unhandled CPU exception 0x%x - aborting\n",
trapnr);
ERROR: space required before the open parenthesis '('
#439: FILE: linux-user/arm/cpu_loop.c:438:
+ for(i = 0; i < 16; i++) {
total: 42 errors, 1 warnings, 889 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 27/42: linux-user: move sparc/sparc64 cpu loop to sparc
directory...
ERROR: do not use C99 // comments
#337: FILE: linux-user/sparc/cpu_loop.c:26:
+//#define DEBUG_WIN
ERROR: braces {} are necessary for all arms of this statement
#346: FILE: linux-user/sparc/cpu_loop.c:35:
+ if (index < 8 && env->cwp == env->nwindows - 1)
[...]
ERROR: braces {} are necessary for all arms of this statement
#359: FILE: linux-user/sparc/cpu_loop.c:48:
+ if (sp_ptr & 3)
[...]
ERROR: space required before the open parenthesis '('
#366: FILE: linux-user/sparc/cpu_loop.c:55:
+ for(i = 0; i < 16; i++) {
ERROR: braces {} are necessary for all arms of this statement
#405: FILE: linux-user/sparc/cpu_loop.c:94:
+ if (sp_ptr & 3)
[...]
ERROR: space required before the open parenthesis '('
#412: FILE: linux-user/sparc/cpu_loop.c:101:
+ for(i = 0; i < 16; i++) {
ERROR: braces {} are necessary for all arms of this statement
#419: FILE: linux-user/sparc/cpu_loop.c:108:
+ if (env->cleanwin < env->nwindows - 1)
[...]
ERROR: space required before the open parenthesis '('
#432: FILE: linux-user/sparc/cpu_loop.c:121:
+ for(;;) {
ERROR: braces {} are necessary for all arms of this statement
#436: FILE: linux-user/sparc/cpu_loop.c:125:
+ if (env->wim & (1 << cwp1))
[...]
ERROR: braces {} are necessary for all arms of this statement
#439: FILE: linux-user/sparc/cpu_loop.c:128:
+ if (env->canrestore == 0)
[...]
ERROR: space prohibited between function name and open parenthesis '('
#457: FILE: linux-user/sparc/cpu_loop.c:146:
+void cpu_loop (CPUSPARCState *env)
ERROR: space prohibited between function name and open parenthesis '('
#483: FILE: linux-user/sparc/cpu_loop.c:172:
+ ret = do_syscall (env, env->gregs[1],
ERROR: braces {} are necessary for all arms of this statement
#551: FILE: linux-user/sparc/cpu_loop.c:240:
+ if (trapnr == TT_DFAULT)
[...]
+ else
[...]
ERROR: that open brace { should be on the previous line
#586: FILE: linux-user/sparc/cpu_loop.c:275:
+ if (sig)
+ {
ERROR: space prohibited between function name and open parenthesis '('
#599: FILE: linux-user/sparc/cpu_loop.c:288:
+ printf ("Unhandled trap: 0x%x\n", trapnr);
ERROR: space prohibited between function name and open parenthesis '('
#603: FILE: linux-user/sparc/cpu_loop.c:292:
+ process_pending_signals (env);
ERROR: space required before the open parenthesis '('
#613: FILE: linux-user/sparc/cpu_loop.c:302:
+ for(i = 0; i < 8; i++)
ERROR: braces {} are necessary for all arms of this statement
#613: FILE: linux-user/sparc/cpu_loop.c:302:
+ for(i = 0; i < 8; i++)
[...]
ERROR: space required before the open parenthesis '('
#615: FILE: linux-user/sparc/cpu_loop.c:304:
+ for(i = 0; i < 8; i++)
ERROR: braces {} are necessary for all arms of this statement
#615: FILE: linux-user/sparc/cpu_loop.c:304:
+ for(i = 0; i < 8; i++)
[...]
total: 20 errors, 0 warnings, 597 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 28/42: linux-user: move ppc/ppc64 cpu loop to ppc directory...
ERROR: space prohibited between function name and open parenthesis '('
#626: FILE: linux-user/ppc/cpu_loop.c:50:
+__attribute__ (( alias ("cpu_ppc_load_tbu") ));
ERROR: space prohibited after that open parenthesis '('
#626: FILE: linux-user/ppc/cpu_loop.c:50:
+__attribute__ (( alias ("cpu_ppc_load_tbu") ));
ERROR: space prohibited before that close parenthesis ')'
#626: FILE: linux-user/ppc/cpu_loop.c:50:
+__attribute__ (( alias ("cpu_ppc_load_tbu") ));
ERROR: space prohibited between function name and open parenthesis '('
#634: FILE: linux-user/ppc/cpu_loop.c:58:
+int ppc_dcr_read (ppc_dcr_t *dcr_env, int dcrn, uint32_t *valp)
ERROR: space prohibited between function name and open parenthesis '('
#639: FILE: linux-user/ppc/cpu_loop.c:63:
+int ppc_dcr_write (ppc_dcr_t *dcr_env, int dcrn, uint32_t val)
ERROR: trailing statements should be on next line
#666: FILE: linux-user/ppc/cpu_loop.c:90:
+ case 1: segv = get_user_u8(val, addr); break;
ERROR: trailing statements should be on next line
#667: FILE: linux-user/ppc/cpu_loop.c:91:
+ case 2: segv = get_user_u16(val, addr); break;
ERROR: trailing statements should be on next line
#668: FILE: linux-user/ppc/cpu_loop.c:92:
+ case 4: segv = get_user_u32(val, addr); break;
ERROR: trailing statements should be on next line
#670: FILE: linux-user/ppc/cpu_loop.c:94:
+ case 8: segv = get_user_u64(val, addr); break;
ERROR: trailing statements should be on next line
#679: FILE: linux-user/ppc/cpu_loop.c:103:
+ default: abort();
ERROR: trailing statements should be on next line
#684: FILE: linux-user/ppc/cpu_loop.c:108:
+ case 1: segv = put_user_u8(val, addr); break;
ERROR: trailing statements should be on next line
#685: FILE: linux-user/ppc/cpu_loop.c:109:
+ case 2: segv = put_user_u16(val, addr); break;
ERROR: trailing statements should be on next line
#686: FILE: linux-user/ppc/cpu_loop.c:110:
+ case 4: segv = put_user_u32(val, addr); break;
ERROR: trailing statements should be on next line
#688: FILE: linux-user/ppc/cpu_loop.c:112:
+ case 8: segv = put_user_u64(val, addr); break;
ERROR: spaces required around that '+' (ctx:VxV)
#693: FILE: linux-user/ppc/cpu_loop.c:117:
+ val = env->gpr[reg+1];
^
ERROR: spaces required around that '+' (ctx:VxV)
#695: FILE: linux-user/ppc/cpu_loop.c:119:
+ val2 = env->gpr[reg+1];
^
ERROR: trailing statements should be on next line
#705: FILE: linux-user/ppc/cpu_loop.c:129:
+ default: abort();
ERROR: space required before the open parenthesis '('
#730: FILE: linux-user/ppc/cpu_loop.c:154:
+ for(;;) {
ERROR: space required before the open parenthesis '('
#736: FILE: linux-user/ppc/cpu_loop.c:160:
+ switch(trapnr) {
ERROR: space required before the open parenthesis '('
#1152: FILE: linux-user/ppc/cpu_loop.c:576:
+ for(i = 0; i < 32; i++) {
total: 20 errors, 0 warnings, 1131 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 29/42: linux-user: move mips/mips64 cpu loop to mips directory...
ERROR: Macros with complex values should be enclosed in parenthesis
#775: FILE: linux-user/mips/cpu_loop.c:26:
+# define MIPS_SYS(name, args) args,
ERROR: space required before the open parenthesis '('
#1234: FILE: linux-user/mips/cpu_loop.c:485:
+ for(;;) {
ERROR: space required before the open parenthesis '('
#1240: FILE: linux-user/mips/cpu_loop.c:491:
+ switch(trapnr) {
ERROR: do not use assignment in if condition
#1257: FILE: linux-user/mips/cpu_loop.c:508:
+ if ((ret = get_user_ual(arg8, sp_reg + 28)) != 0) {
ERROR: do not use assignment in if condition
#1261: FILE: linux-user/mips/cpu_loop.c:512:
+ if ((ret = get_user_ual(arg7, sp_reg + 24)) != 0) {
ERROR: do not use assignment in if condition
#1265: FILE: linux-user/mips/cpu_loop.c:516:
+ if ((ret = get_user_ual(arg6, sp_reg + 20)) != 0) {
ERROR: do not use assignment in if condition
#1269: FILE: linux-user/mips/cpu_loop.c:520:
+ if ((ret = get_user_ual(arg5, sp_reg + 16)) != 0) {
ERROR: that open brace { should be on the previous line
#1333: FILE: linux-user/mips/cpu_loop.c:584:
+ if (sig)
+ {
WARNING: line over 80 characters
#1463: FILE: linux-user/mips/cpu_loop.c:714:
+ EXCP_DUMP(env, "qemu: unhandled CPU exception 0x%x - aborting\n",
trapnr);
ERROR: space required before the open parenthesis '('
#1477: FILE: linux-user/mips/cpu_loop.c:728:
+ for(i = 0; i < 32; i++) {
total: 9 errors, 1 warnings, 1478 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 30/42: linux-user: move nios2 cpu loop to nios2 directory...
Checking PATCH 31/42: linux-user: move openrisc cpu loop to openrisc
directory...
Checking PATCH 32/42: linux-user: move sh4 cpu loop to sh4 directory...
ERROR: space prohibited between function name and open parenthesis '('
#197: FILE: linux-user/sh4/cpu_loop.c:87:
+ printf ("Unhandled trap: 0x%x\n", trapnr);
ERROR: space prohibited between function name and open parenthesis '('
#201: FILE: linux-user/sh4/cpu_loop.c:91:
+ process_pending_signals (env);
ERROR: space required before the open parenthesis '('
#217: FILE: linux-user/sh4/cpu_loop.c:107:
+ for(i = 0; i < 16; i++) {
total: 3 errors, 0 warnings, 193 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 33/42: linux-user: move cris cpu loop to cris directory...
ERROR: trailing whitespace
#31: FILE: linux-user/cris/cpu_loop.c:29:
+ $
ERROR: trailing whitespace
#53: FILE: linux-user/cris/cpu_loop.c:51:
+ ret = do_syscall(env, $
ERROR: trailing whitespace
#54: FILE: linux-user/cris/cpu_loop.c:52:
+ env->regs[9], $
ERROR: trailing whitespace
#55: FILE: linux-user/cris/cpu_loop.c:53:
+ env->regs[10], $
ERROR: trailing whitespace
#56: FILE: linux-user/cris/cpu_loop.c:54:
+ env->regs[11], $
ERROR: trailing whitespace
#57: FILE: linux-user/cris/cpu_loop.c:55:
+ env->regs[12], $
ERROR: trailing whitespace
#58: FILE: linux-user/cris/cpu_loop.c:56:
+ env->regs[13], $
ERROR: trailing whitespace
#59: FILE: linux-user/cris/cpu_loop.c:57:
+ env->pregs[7], $
ERROR: that open brace { should be on the previous line
#73: FILE: linux-user/cris/cpu_loop.c:71:
+ if (sig)
+ {
ERROR: space prohibited between function name and open parenthesis '('
#86: FILE: linux-user/cris/cpu_loop.c:84:
+ printf ("Unhandled trap: 0x%x\n", trapnr);
ERROR: space prohibited between function name and open parenthesis '('
#90: FILE: linux-user/cris/cpu_loop.c:88:
+ process_pending_signals (env);
total: 11 errors, 0 warnings, 197 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 34/42: linux-user: move microblaze cpu loop to microblaze
directory...
ERROR: trailing whitespace
#204: FILE: linux-user/microblaze/cpu_loop.c:29:
+ $
ERROR: trailing whitespace
#229: FILE: linux-user/microblaze/cpu_loop.c:54:
+ ret = do_syscall(env, $
ERROR: trailing whitespace
#230: FILE: linux-user/microblaze/cpu_loop.c:55:
+ env->regs[12], $
ERROR: trailing whitespace
#231: FILE: linux-user/microblaze/cpu_loop.c:56:
+ env->regs[5], $
ERROR: trailing whitespace
#232: FILE: linux-user/microblaze/cpu_loop.c:57:
+ env->regs[6], $
ERROR: trailing whitespace
#233: FILE: linux-user/microblaze/cpu_loop.c:58:
+ env->regs[7], $
ERROR: trailing whitespace
#234: FILE: linux-user/microblaze/cpu_loop.c:59:
+ env->regs[8], $
ERROR: trailing whitespace
#235: FILE: linux-user/microblaze/cpu_loop.c:60:
+ env->regs[9], $
ERROR: switch and case should be at the same indent
#262: FILE: linux-user/microblaze/cpu_loop.c:87:
+ switch (env->sregs[SR_ESR] & 31) {
+ case ESR_EC_DIVZERO:
[...]
+ case ESR_EC_FPU:
[...]
+ default:
ERROR: space prohibited between function name and open parenthesis '('
#283: FILE: linux-user/microblaze/cpu_loop.c:108:
+ printf ("Unhandled hw-exception: 0x%x\n",
ERROR: that open brace { should be on the previous line
#295: FILE: linux-user/microblaze/cpu_loop.c:120:
+ if (sig)
+ {
ERROR: space prohibited between function name and open parenthesis '('
#308: FILE: linux-user/microblaze/cpu_loop.c:133:
+ printf ("Unhandled trap: 0x%x\n", trapnr);
ERROR: space prohibited between function name and open parenthesis '('
#312: FILE: linux-user/microblaze/cpu_loop.c:137:
+ process_pending_signals (env);
total: 13 errors, 0 warnings, 323 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 35/42: linux-user: move m68k cpu loop to m68k directory...
ERROR: space required before the open parenthesis '('
#30: FILE: linux-user/m68k/cpu_loop.c:32:
+ for(;;) {
ERROR: space required before the open parenthesis '('
#36: FILE: linux-user/m68k/cpu_loop.c:38:
+ switch(trapnr) {
ERROR: that open brace { should be on the previous line
#118: FILE: linux-user/m68k/cpu_loop.c:120:
+ if (sig)
+ {
WARNING: line over 80 characters
#131: FILE: linux-user/m68k/cpu_loop.c:133:
+ EXCP_DUMP(env, "qemu: unhandled CPU exception 0x%x - aborting\n",
trapnr);
total: 3 errors, 1 warnings, 318 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 36/42: linux-user: move alpha cpu loop to alpha directory...
ERROR: space prohibited between function name and open parenthesis '('
#201: FILE: linux-user/alpha/cpu_loop.c:199:
+ printf ("Unhandled trap: 0x%x\n", trapnr);
ERROR: space prohibited between function name and open parenthesis '('
#205: FILE: linux-user/alpha/cpu_loop.c:203:
+ process_pending_signals (env);
ERROR: space required before the open parenthesis '('
#222: FILE: linux-user/alpha/cpu_loop.c:220:
+ for(i = 0; i < 28; i++) {
total: 3 errors, 0 warnings, 421 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 37/42: linux-user: move s390x cpu loop to s390x directory...
ERROR: space prohibited between function name and open parenthesis '('
#320: FILE: linux-user/s390x/cpu_loop.c:153:
+ process_pending_signals (env);
total: 1 errors, 0 warnings, 303 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 38/42: linux-user: move tilegx cpu loop to tilegx directory...
Checking PATCH 39/42: linux-user: move riscv cpu loop to riscv directory...
Checking PATCH 40/42: linux-user: move hppa cpu loop to hppa directory...
Checking PATCH 41/42: linux-user: move xtensa cpu loop to xtensa directory...
Checking PATCH 42/42: linux-user: Add ARM get_tls syscall support...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [qemu-s390x] [PULL 37/42] linux-user: move s390x cpu loop to s390x directory, (continued)
- [qemu-s390x] [PULL 37/42] linux-user: move s390x cpu loop to s390x directory, Laurent Vivier, 2018/04/30
- [qemu-s390x] [PULL 21/42] linux-user: move ppc/ppc64 signal.c parts to ppc directory, Laurent Vivier, 2018/04/30
- [qemu-s390x] [PULL 36/42] linux-user: move alpha cpu loop to alpha directory, Laurent Vivier, 2018/04/30
- [qemu-s390x] [PULL 32/42] linux-user: move sh4 cpu loop to sh4 directory, Laurent Vivier, 2018/04/30
- [qemu-s390x] [PULL 39/42] linux-user: move riscv cpu loop to riscv directory, Laurent Vivier, 2018/04/30
- [qemu-s390x] [PULL 20/42] linux-user: move mips/mips64 signal.c parts to mips directory, Laurent Vivier, 2018/04/30
- [qemu-s390x] [PULL 35/42] linux-user: move m68k cpu loop to m68k directory, Laurent Vivier, 2018/04/30
- [qemu-s390x] [PULL 27/42] linux-user: move sparc/sparc64 cpu loop to sparc directory, Laurent Vivier, 2018/04/30
- [qemu-s390x] [PULL 29/42] linux-user: move mips/mips64 cpu loop to mips directory, Laurent Vivier, 2018/04/30
- Re: [qemu-s390x] [Qemu-devel] [PULL 00/42] Linux user for 2.13 patches, Peter Maydell, 2018/04/30
- Re: [qemu-s390x] [Qemu-devel] [PULL 00/42] Linux user for 2.13 patches,
no-reply <=