[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PATCH 2/3] pc-bios/s390-ccw/net: Add support for pxeli

From: Farhan Ali
Subject: Re: [qemu-s390x] [PATCH 2/3] pc-bios/s390-ccw/net: Add support for pxelinux-style config files
Date: Fri, 1 Jun 2018 16:19:50 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

On 05/31/2018 11:21 PM, Thomas Huth wrote:
Just a question do we want to clear cfgbuf here, before calling
That's theoretically not necessary. The buffer either gets populated
with data, or the function errors out. The code also makes sure that
there is a final NUL-character in the buffer:


... but I think I've got to double check that there is also a
NUL-character immediately at the end of the downloaded data ... so
there's indeed a change required, but likely rather in the SLOF code
than here.


Can't we do that in net_try_direct_tftp_load, or it is better to put that in SLOF code?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]