[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [Qemu-devel] [PATCH v3] loader: Check access size when

From: Christian Borntraeger
Subject: Re: [qemu-s390x] [Qemu-devel] [PATCH v3] loader: Check access size when calling rom_ptr() to avoid crashes
Date: Mon, 25 Jun 2018 14:50:49 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 06/25/2018 10:31 AM, Thomas Huth wrote:
> On 15.06.2018 11:49, Thomas Huth wrote:
>> The rom_ptr() function allows direct access to the ROM blobs that we
>> load during startup. However, there are currently no checks for the
>> size of the accesses, so it's currently possible to crash QEMU for
>> example with:
>> $ echo "Insane in the mainframe" > /tmp/test.txt
>> $ s390x-softmmu/qemu-system-s390x -kernel /tmp/test.txt -append xyz
>> Segmentation fault (core dumped)
>> $ s390x-softmmu/qemu-system-s390x -kernel /tmp/test.txt -initrd /tmp/test.txt
>> Segmentation fault (core dumped)
>> $ echo -n HdrS > /tmp/hdr.txt
>> $ sparc64-softmmu/qemu-system-sparc64 -kernel /tmp/hdr.txt -initrd 
>> /tmp/hdr.txt
>> Segmentation fault (core dumped)
>> We need a possibility to check the size of the ROM area that we want
>> to access, thus let's add a size parameter to the rom_ptr() function
>> to avoid these problems.
>> Signed-off-by: Thomas Huth <address@hidden>
> Ping!
> Could anybody please pick this patch up? Qemu-trivial seems to be pretty
> dormant these days (?), so maybe Paolo via misc? Or either the s390x or
> Sparc tree, since it fixes a crash on these machines?

Acked-by: Christian Borntraeger <address@hidden>

if this will go via the s390x tree.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]