[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PATCH v1] s390x/tcg: fix locking problem with tcg_s390

From: Cornelia Huck
Subject: Re: [qemu-s390x] [PATCH v1] s390x/tcg: fix locking problem with tcg_s390_tod_updated
Date: Mon, 2 Jul 2018 10:30:19 +0200

On Fri, 29 Jun 2018 19:05:20 +0200
David Hildenbrand <address@hidden> wrote:

> tcg_s390_tod_updated() is always called with the iothread being locked
> (e.g. from S390TODClass->set() e.g. via HELPER(sck) or on incomming


> migration). The helper we call takes the lock itself - bad.
> Let's change that by factoring out updating the ckc timer. This now looks
> much nicer than having to call a helper from another function.
> While touch it we also make sure that env->ckc is updated even if the new


> value is -1ULL, for now it would not have been modified in that case.
> Reported-by: Christian Borntraeger <address@hidden>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> This survives my tests and the iotests Christian mentioned.

OK, this will the last patch (I guess) before I send my final 3.0 pull

>  target/s390x/misc_helper.c | 26 ++++++++++++++++----------
>  1 file changed, 16 insertions(+), 10 deletions(-)

Thanks, applied.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]