[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PATCH v6 4/5] s390x/vfio: ap: Introduce VFIO AP device

From: Tony Krowiak
Subject: Re: [qemu-s390x] [PATCH v6 4/5] s390x/vfio: ap: Introduce VFIO AP device
Date: Fri, 13 Jul 2018 15:21:29 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0

On 07/04/2018 01:24 PM, Cornelia Huck wrote:
On Fri, 29 Jun 2018 18:48:02 -0400
Tony Krowiak <address@hidden> wrote:

Introduces a VFIO based AP device. The device is defined via
the QEMU command line by specifying:

     -device vfio-ap,sysfsdev=<path-to-mediated-matrix-device>

There may be only one vfio-ap device configured for a guest.

The mediated matrix device is created by the VFIO AP device
driver by writing a UUID to a sysfs attribute file (see
docs/vfio-ap.txt). The mediated matrix device will be named
after the UUID. Symbolic links to the $uuid are created in
many places, so the path to the mediated matrix device $uuid
can be specified in any of the following ways:


When the vfio-ap device is realized, it acquires and opens the
VFIO iommu group to which the mediated matrix device is
bound. This causes a VFIO group notification event to be
signaled. The vfio_ap device driver's group notification
handler will get called at which time the device driver
will configure the the AP devices to which the guest will
be granted access.

Signed-off-by: Tony Krowiak <address@hidden>
Signed-off-by: Tony Krowiak <address@hidden>
Nit: You may want to decide one address or the other :)

Unintentional .... I'll correct it.

  MAINTAINERS                       |    1 +
  default-configs/s390x-softmmu.mak |    1 +
  hw/vfio/Makefile.objs             |    1 +
  hw/vfio/ap.c                      |  183 +++++++++++++++++++++++++++++++++++++
  include/hw/vfio/vfio-common.h     |    1 +
  5 files changed, 187 insertions(+), 0 deletions(-)
  create mode 100644 hw/vfio/ap.c
No complaints about the code from me.

I like no complaints:)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]