[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PATCH] target/s390x/excp_helper: Remove DPRINTF() macr

From: Cornelia Huck
Subject: Re: [qemu-s390x] [PATCH] target/s390x/excp_helper: Remove DPRINTF() macro
Date: Mon, 8 Oct 2018 12:01:30 +0200

On Fri,  5 Oct 2018 17:00:01 +0200
Thomas Huth <address@hidden> wrote:

> Debug macros that are disabled by default should be avoided (since the
> code bit-rots quite easily). Thus turn these debug prints into proper
> qemu_log_mask(CPU_LOG_xxx, ...) statements instead. The DPRINTF statements
> in do_[ext|io|mchk]_interrupt can even be removed completely since we can
> log the information in a central place, s390_cpu_do_interrupt, instead.
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  target/s390x/excp_helper.c | 48 
> +++++++++++-----------------------------------
>  1 file changed, 11 insertions(+), 37 deletions(-)

[patch had gained a trivial-to-fix contextual conflict in the
meanwhile; fixed]

Thanks, applied.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]