[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PATCH v10 6/6] s390: doc: detailed specifications for

From: Tony Krowiak
Subject: Re: [qemu-s390x] [PATCH v10 6/6] s390: doc: detailed specifications for AP virtualization
Date: Wed, 10 Oct 2018 10:23:23 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0

On 10/10/2018 04:14 AM, Thomas Huth wrote:
On 2018-10-09 19:52, Tony Krowiak wrote:
This patch provides documentation describing the AP architecture and
design concepts behind the virtualization of AP devices. It also
includes an example of how to configure AP devices for exclusive
use of KVM guests.

Signed-off-by: Tony Krowiak <address@hidden>
Reviewed-by: Pierre Morel<address@hidden>
Tested-by: Pierre Morel<address@hidden>
  MAINTAINERS      |   1 +
  docs/vfio-ap.txt | 825 +++++++++++++++++++++++++++++++++++++++++++++++
  2 files changed, 826 insertions(+)
  create mode 100644 docs/vfio-ap.txt
+      * Individual bits in the mask can be switched on and off by specifying
+        each bit number to be switched in a comma separated list. Each bit
+        number string must be prepended with a ('+') or minus ('-') to indicate
+        the corresponding bit is to be switched on ('+') or off ('-'). Some
+        valid values are:

Nit: My git complains about a superfluous white space after "are:"

I ran checkpatch and my git did not complain, but I'll make sure there
are no whitespaces at the end of the lines.

+   To assign an AP adapter to the mediated matrix device, its APID is written
+   to the 'assign_adapter' file. This may be done multiple times to assign more
+   than one adapter. The APID may be specified using conventional semantics
+   as a decimal, hexidecimal, or octal number. For example, to assign adapters
+   4, 5 and 16 to a mediated matrix device in decimal, hexidecimal and octal
+   respectively:

In case you respin: I'd still prefer s/hexidecimal/hexadecimal/g in the
whole document (but it's just a nit, so no need to respin just because
of this)

I will be submitting a v11, so I'll go ahead and fix this.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]