[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [Qemu-devel] [PATCH] Clean up includes

From: Cornelia Huck
Subject: Re: [qemu-s390x] [Qemu-devel] [PATCH] Clean up includes
Date: Wed, 5 Dec 2018 11:45:47 +0100

On Wed, 05 Dec 2018 09:07:13 +0100
Markus Armbruster <address@hidden> wrote:

> > On 12/4/18 11:25 AM, Markus Armbruster wrote:  
> >> Clean up includes so that osdep.h is included first and headers
> >> which it implies are not included manually.
> >>
> >> This commit was created with scripts/clean-includes, with the changes
> >> to the following files manually reverted:


> >>      target/s390x/gen-features.c


> target/s390x/gen-features.c is a standalone program that is compiled in
> a way that breaks when we include osdep.h.  If that's fixable, fixing it
> would be nice.  Aside: not sure I'd have written this in C.

Yes, that file is a bit of an oddball. Might make sense to add a
comment there that it is standalone, so you can find that out without
looking at the Makefile. I don't think rewriting this to something else
is worth the effort.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]