[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PATCH RFC] vfio-ap: flag as compatible with balloon

From: Tony Krowiak
Subject: Re: [qemu-s390x] [PATCH RFC] vfio-ap: flag as compatible with balloon
Date: Thu, 6 Dec 2018 18:01:24 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

On 12/5/18 9:51 AM, Cornelia Huck wrote:
vfio-ap devices do not pin any pages in the host. Therefore, they
are belived to be compatible with memory ballooning.

Flag them as compatible, so both vfio-ap and a balloon can be
used simultaneously.

Signed-off-by: Cornelia Huck <address@hidden>

As briefly discussed on IRC. RFC as I do not have easy access to
hardware I can test this with.

  hw/vfio/ap.c | 8 ++++++++
  1 file changed, 8 insertions(+)

diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index 65de952f44..3bf48eed28 100644
--- a/hw/vfio/ap.c
+++ b/hw/vfio/ap.c
@@ -104,6 +104,14 @@ static void vfio_ap_realize(DeviceState *dev, Error **errp)
      vapdev->vdev.name = g_strdup_printf("%s", mdevid);
      vapdev->vdev.dev = dev;
+ /*
+     * vfio-ap devices are believed to operate in a way compatible with
+     * memory ballooning, as no pages are pinned in the host.
+     * This needs to be set before vfio_get_device() for vfio common to
+     * handle the balloon inhibitor.
+     */
+    vapdev->vdev.balloon_allowed = true;
      ret = vfio_get_device(vfio_group, mdevid, &vapdev->vdev, &local_err);
      if (ret) {
          goto out_get_dev_err;

Tested-by: Tony Krowiak <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]