Re: [qemu-s390x] [Qemu-devel] [PATCH] hw/s390x: Fix bad mask in time2tod()

[Philippe Mathieu-Daudé]

On 12/14/18 2:30 PM, Thomas Huth wrote:
> On 2018-12-14 14:26, Christian Borntraeger wrote:
>>
>>
>> On 14.12.2018 14:23, Thomas Huth wrote:
>>> On 2018-12-14 14:15, Christian Borntraeger wrote:
>>>>
>>>>
>>>> On 14.12.2018 14:08, Thomas Huth wrote:
>>>>> The time2tod() function tries to deal with the 9 uppermost bits in the
>>>>> time value, but uses the wrong mask for this: 0xff80000000000000 should
>>>>> be used instead of 0xff10000000000000 here.
>>>>>
>>>>> Fixes: 14055ce53c2d901d826ffad7fb7d6bb8ab46bdfd
>>>>
>>>> Can you alsways have commit id and subject
>>>>
>>>> like
>>>> Fixes: 14055ce53c2d ("s390x/tcg: avoid overflows in time2tod/tod2time")
>>>
>>> In https://wiki.qemu.org/Contribute/SubmitAPatch we currently have:
>>>
>>>  Fixes: <full-SHA-commit-id>
>>
>> Interesting. Linus strongly opposed to only have the commit id as people 
>> often
>> do cut and paste errors so nobody could actually find out which commit was 
>> meant.
>> So the Linux variant is not sha commit of at least 12 digits + subject.
> 
> Mentioning the title certainly makes sense, too, so feel free to extend
> the Wiki page if you like!

Done :)