[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH 02/18] Acceptance tests: show avocado test execu
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [qemu-s390x] [PATCH 02/18] Acceptance tests: show avocado test execution by default |
Date: |
Tue, 22 Jan 2019 10:50:32 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 1/17/19 7:56 PM, Cleber Rosa wrote:
> The current version of the "check-acceptance" target will only show
> one line for execution of all tests. That's probably OK if the tests
> to be run are quick enough and they're always the same.
>
> But, there's already one test alone that takes on average ~5 seconds
> to run, we intend to adapt the list of tests to match the user's build
> environment (among other choices).
>
> Because of that, let's present the default Avocado UI by default.
> Users can always choose a different output by setting the AVOCADO_SHOW
> variable.
>
> Signed-off-by: Cleber Rosa <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> .travis.yml | 2 +-
> tests/Makefile.include | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 93fd0164a0..844d514afa 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -188,7 +188,7 @@ matrix:
> # Acceptance (Functional) tests
> - env:
> - CONFIG="--python=/usr/bin/python3 --target-list=x86_64-softmmu"
> - - TEST_CMD="make AVOCADO_SHOW=app check-acceptance"
> + - TEST_CMD="make check-acceptance"
> addons:
> apt:
> packages:
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index f403a6571d..c73298740d 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -956,7 +956,7 @@ TESTS_RESULTS_DIR=$(BUILD_DIR)/tests/results
> # Controls the output generated by Avocado when running tests.
> # Any number of command separated loggers are accepted. For more
> # information please refer to "avocado --help".
> -AVOCADO_SHOW=none
> +AVOCADO_SHOW=app
>
> PYTHON3 = $(shell $(PYTHON) -c 'import sys; print(1 if sys.version_info >=
> (3, 0) else 0)')
> ifeq ($(PYTHON3), 1)
>