[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v1 6/6] softfloat: Support float_round_to_odd mo
From: |
Alex Bennée |
Subject: |
Re: [qemu-s390x] [PATCH v1 6/6] softfloat: Support float_round_to_odd more places |
Date: |
Sat, 23 Feb 2019 10:11:46 +0000 |
User-agent: |
mu4e 1.1.0; emacs 26.1 |
Richard Henderson <address@hidden> writes:
> On 2/22/19 12:45 PM, Alex Bennée wrote:
>> @@ -3526,6 +3551,8 @@ static float32 roundAndPackFloat32(flag zSign, int
>> zExp, uint32_t zSig,
>> case float_round_down:
>> roundIncrement = zSign ? 0x7f : 0;
>> break;
>> + case float_round_to_odd:
>> + roundIncrement = zSig & 0x80 ? 0 : 0x7f;
>> default:
>> abort();
>
> I clearly missed a break here.
>
> Since this didn't kill fp-test, are we missing a float128_to_float32
> test?
Ahh yes missing that:
10:11:17 address@hidden:~/l/q/b/a/t/fp] fpu/next + ./fp-test f16_to_f32
f64_to_f32 f128_to_f32 -r odd
>> Testing f16_to_f32
408 tests total.
408 tests performed.
In 408 tests, no errors found in f16_to_f32.
>> Testing f64_to_f32, rounding odd, tininess before rounding
768 tests total.
768 tests performed.
In 768 tests, no errors found in f64_to_f32, rounding odd, tininess before
rounding.
>> Testing f64_to_f32, rounding odd, tininess after rounding
768 tests total.
768 tests performed.
In 768 tests, no errors found in f64_to_f32, rounding odd, tininess after
rounding.
>> Testing f128_to_f32, rounding odd, tininess before rounding
936 tests total.
fish: “./fp-test f16_to_f32 f64_to_f32…” terminated by signal SIGABRT (Abort)
I'll patch it up and fix.
>
>
> r~
--
Alex Bennée
- [qemu-s390x] [PATCH v1 0/6] fpu/next, mostly bits s390x tcg will need, Alex Bennée, 2019/02/22
- [qemu-s390x] [PATCH v1 5/6] tests/fp: enable f128_to_ui[32/64] tests in float-to-uint, Alex Bennée, 2019/02/22
- [qemu-s390x] [PATCH v1 3/6] softfloat: Implement float128_to_uint32, Alex Bennée, 2019/02/22
- [qemu-s390x] [PATCH v1 6/6] softfloat: Support float_round_to_odd more places, Alex Bennée, 2019/02/22
- [qemu-s390x] [PATCH v1 4/6] tests/fp: add wrapping for f128_to_ui32, Alex Bennée, 2019/02/22
- [qemu-s390x] [PATCH v1 2/6] softfloat: add float128_is_{normal, denormal}, Alex Bennée, 2019/02/22
- [qemu-s390x] [PATCH v1 1/6] tests: Ignore fp test outputs, Alex Bennée, 2019/02/22