[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [Qemu-devel] [PATCH v1 5/7] s390x/tcg: Factor out gen_a
From: |
Richard Henderson |
Subject: |
Re: [qemu-s390x] [Qemu-devel] [PATCH v1 5/7] s390x/tcg: Factor out gen_addi_and_wrap_i64() from get_address() |
Date: |
Mon, 25 Feb 2019 07:53:41 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/25/19 3:55 AM, David Hildenbrand wrote:
> Also properly wrap in 24bit mode. While at it, convert the comment (and
> drop the comment about fundamental TCG optimizations).
>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> target/s390x/translate.c | 41 +++++++++++++++++++++++++---------------
> 1 file changed, 26 insertions(+), 15 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
> +static inline void gen_addi_and_wrap_i64(DisasContext *s, TCGv_i64 dst,
> + TCGv_i64 src, int64_t imm)
I would drop the inline and let the compiler choose.
I'm using very few explicit inline markers these days...
r~
[qemu-s390x] [PATCH v1 6/7] s390x/tcg: Implement LOAD LENGTHENED short HFP to long HFP, David Hildenbrand, 2019/02/25
[qemu-s390x] [PATCH v1 1/7] s390x/tcg: RXE has an optional M3 field, David Hildenbrand, 2019/02/25