[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [Qemu-devel] [PATCH v2 00/20] Invert Endian bit in SPAR

From: tony.nguyen
Subject: Re: [qemu-s390x] [Qemu-devel] [PATCH v2 00/20] Invert Endian bit in SPARCv9 MMU TTE
Date: Mon, 22 Jul 2019 16:28:10 +0000

On 7/22/19 8:59 AM, Richard Henderson wrote:

>On 7/22/19 8:34 AM, address@hidden wrote:
>> Tony Nguyen (20):
>>   tcg: Replace MO_8 with MO_UB alias
>>   tcg: Replace MO_16 with MO_UW alias
>>   tcg: Replace MO_32 with MO_UL alias
>>   tcg: Replace MO_64 with MO_UQ alias
>>   tcg: Move size+sign+endian from TCGMemOp to MemOp
>I don't like any of these first 5 patches.
>I don't understand your motivation here.  Why?

The motivation is to only move the attributes required by the memory API
from TCGMemOp into accelerator independent MemOp.

Once I moved MO_{8|16|32|64} into MemOp, there arose many -Wenum-compare and
-Wenum-conversion as a TCGMemOp and a MemOp are being compared and implicitly

Thus the idea to replace MO_{8|16|32|64} with MO_{UB|UW|UL|UQ} so we remain
comparing and coercing the same enum type, both TCGMemOps.

Do you prefer the v1 implementation of making TCGMemOp -> MemOp?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]