[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [Qemu-devel] [PATCH v5 11/15] memory: Single byte swap

From: Paolo Bonzini
Subject: Re: [qemu-s390x] [Qemu-devel] [PATCH v5 11/15] memory: Single byte swap along the I/O path
Date: Fri, 26 Jul 2019 11:26:52 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 26/07/19 08:47, address@hidden wrote:
> +        op = SIZE_MEMOP(size);
> +        if (need_bswap(big_endian)) {
> +            op ^= MO_BSWAP;
> +        }

And this has the same issue as the first version.  It should be

        op = SIZE_MEMOP(size) | (big_endian ? MO_BE : MO_LE);

and everything should work.  If it doesn't (and indeed it doesn't :)) it
means you have bugs somewhere else.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]