[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH for-4.1?] compat: disable edid on virtio-gpu bas
From: |
Cornelia Huck |
Subject: |
Re: [qemu-s390x] [PATCH for-4.1?] compat: disable edid on virtio-gpu base device |
Date: |
Thu, 22 Aug 2019 16:03:33 +0200 |
On Thu, 22 Aug 2019 15:58:32 +0200
Cornelia Huck <address@hidden> wrote:
> 'edid' is a property of the virtio-gpu base device, so turning
> it off on virtio-gpu-pci is not enough (it misses -ccw). Turn
> it off on the base device instead.
>
> Fixes: 0a71966253c8 ("edid: flip the default to enabled")
> Signed-off-by: Cornelia Huck <address@hidden>
> ---
>
> Only just noticed this... should we still shove this into 4.1?
> Or do we need a compat 4.1.1 dance for this?
>
> ---
> hw/core/machine.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 28a475ad97a3..32d1ca9abc5a 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -32,7 +32,7 @@ GlobalProperty hw_compat_4_0[] = {
> { "secondary-vga", "edid", "false" },
> { "bochs-display", "edid", "false" },
> { "virtio-vga", "edid", "false" },
> - { "virtio-gpu-pci", "edid", "false" },
> + { "virtio-gpu", "edid", "false" },
> { "virtio-device", "use-started", "false" },
> { "virtio-balloon-device", "qemu-4-0-config-size", "true" },
> { "pl031", "migrate-tick-offset", "false" },
Eh... rm fail. Please ignore that patch :)
- [qemu-s390x] [PULL 0/7] First batch of s390x changes for 4.2, Cornelia Huck, 2019/08/22
- [qemu-s390x] [PATCH for-4.1?] compat: disable edid on virtio-gpu base device, Cornelia Huck, 2019/08/22
- [qemu-s390x] [PULL 1/7] s390x/tcg: Fix VERIM with 32/64 bit elements, Cornelia Huck, 2019/08/22
- [qemu-s390x] [PULL 2/7] s390x/mmu: Trace the right value if setting/getting the storage key fails, Cornelia Huck, 2019/08/22
- [qemu-s390x] [PULL 3/7] s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug(), Cornelia Huck, 2019/08/22
- [qemu-s390x] [PULL 4/7] s390x/tcg: Rework MMU selection for instruction fetches, Cornelia Huck, 2019/08/22
- [qemu-s390x] [PULL 5/7] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE, Cornelia Huck, 2019/08/22
- [qemu-s390x] [PULL 6/7] s390x/mmu: Better storage key reference and change bit handling, Cornelia Huck, 2019/08/22
- [qemu-s390x] [PULL 7/7] s390x/mmu: Factor out storage key handling, Cornelia Huck, 2019/08/22
- Re: [qemu-s390x] [PULL 0/7] First batch of s390x changes for 4.2, Peter Maydell, 2019/08/23