[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] configure: Remove s390 (31-bit mode) from the list of suppor
From: |
Thomas Huth |
Subject: |
Re: [PATCH] configure: Remove s390 (31-bit mode) from the list of supported CPUs |
Date: |
Mon, 30 Sep 2019 09:59:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 30/09/2019 09.51, David Hildenbrand wrote:
> On 28.09.19 21:03, Thomas Huth wrote:
>> On IBM Z, KVM in the kernel is only implemented for 64-bit mode, and
>> with regards to TCG, we also only support 64-bit host CPUs (see the
>> check at the beginning of tcg/s390/tcg-target.inc.c), so we should
>> remove s390 (without "x", i.e. the old 31-bit mode CPUs) from the
>> list of supported CPUs.
>>
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>> configure | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 397bb476e1..a4488c6705 100755
>> --- a/configure
>> +++ b/configure
>> @@ -728,7 +728,7 @@ ARCH=
>> # Normalise host CPU name and set ARCH.
>> # Note that this case should only have supported host CPUs, not guests.
>> case "$cpu" in
>> - ppc|ppc64|s390|s390x|sparc64|x32|riscv32|riscv64)
>> + ppc|ppc64|s390x|sparc64|x32|riscv32|riscv64)
>> supported_cpu="yes"
>> ;;
>> ppc64le)
>>
>
> Not sure if that ever worked
I think it likely worked with dyngen (the predecessor of TCG), see
commit fb3e5849bb1 ... but I think it's broken since QEMU switched from
dyngen to TCG.
Thomas