[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v5 025/126] scripts: add coccinelle script to use auto propagat

From: Eric Blake
Subject: Re: [RFC v5 025/126] scripts: add coccinelle script to use auto propagated errp
Date: Fri, 11 Oct 2019 13:15:15 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0

On 10/11/19 12:12 PM, Eric Blake wrote:
On 10/11/19 11:04 AM, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>

+identifier rule1.fn;
+identifier rule1.local_err;
+ fn(...)
+ {
+     <...
+-    error_free(local_err);
+-    local_err = NULL;
++    error_free_errp(errp);

This does not make sense - error_free_errp() is not defined prior to this series or anywhere in patches 1-24, if I'm reading it correctly.

Apologies - I sent my reply to this message before 21/126 showed up in my inbox, and didn't realize that I had skipped over sequencing. This part is fine after all, but it points to the perils of reviewing a thread as it comes in piecemeal, vs. reviewing an actual branch with all patches instantly available.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]