[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] core: replace getpagesize() with qemu_real_host_page_siz

From: Wei Yang
Subject: Re: [PATCH 2/2] core: replace getpagesize() with qemu_real_host_page_size
Date: Wed, 16 Oct 2019 09:25:18 +0800
User-agent: Mutt/1.9.4 (2018-02-28)

On Sun, Oct 13, 2019 at 08:28:41PM +1100, David Gibson wrote:
>On Sun, Oct 13, 2019 at 10:11:45AM +0800, Wei Yang wrote:
>> There are three page size in qemu:
>>   real host page size
>>   host page size
>>   target page size
>> All of them have dedicate variable to represent. For the last two, we
>> use the same form in the whole qemu project, while for the first one we
>> use two forms: qemu_real_host_page_size and getpagesize().
>> qemu_real_host_page_size is defined to be a replacement of
>> getpagesize(), so let it serve the role.
>> [Note] Not fully tested for some arch or device.
>> Signed-off-by: Wei Yang <address@hidden>
>Reviewed-by: David Gibson <address@hidden>
>Although the chances of someone messing this up again are almost 100%.

Hi, David

I found put a check in checkpatch.pl may be a good way to prevent it.

Just draft a patch, hope you would like it.

>David Gibson                   | I'll have my music baroque, and my code
>david AT gibson.dropbear.id.au | minimalist, thank you.  NOT _the_ _other_
>                               | _way_ _around_!

Wei Yang
Help you, Help me

reply via email to

[Prev in Thread] Current Thread [Next in Thread]