[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] s390x/cpumodel: Add missing visit_free

From: David Hildenbrand
Subject: Re: [PATCH] s390x/cpumodel: Add missing visit_free
Date: Wed, 16 Oct 2019 18:54:19 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1

On 16.10.19 16:54, Andrew Jones wrote:
Beata Michalska noticed this missing visit_free() while reviewing
arm's implementation of qmp_query_cpu_model_expansion(), which is
modeled off this s390x implementation.

Nice to see ARM support getting added.

Signed-off-by: Andrew Jones <address@hidden>
  target/s390x/cpu_models.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
index 009afc38b92d..7e92fb2e156d 100644
--- a/target/s390x/cpu_models.c
+++ b/target/s390x/cpu_models.c
@@ -515,6 +515,7 @@ static void cpu_model_from_info(S390CPUModel *model, const 
CpuModelInfo *info,
          visitor = qobject_input_visitor_new(info->props);
          visit_start_struct(visitor, NULL, NULL, 0, errp);
          if (*errp) {
+            visit_free(visitor);

Right, thanks

Reviewed-by: David Hildenbrand <address@hidden>



David / dhildenb

reply via email to

[Prev in Thread] Current Thread [Next in Thread]