[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 08/13] hw/core: deprecate old reset functions and introduc

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v5 08/13] hw/core: deprecate old reset functions and introduce new ones
Date: Mon, 4 Nov 2019 16:42:02 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1

On 11/4/19 1:01 PM, Damien Hedde wrote:
On 11/1/19 12:35 AM, Philippe Mathieu-Daudé wrote:
On 10/18/19 5:06 PM, Damien Hedde wrote:
Deprecate device_legacy_reset(), qdev_reset_all() and
qbus_reset_all() to be replaced by new functions
device_cold_reset() and bus_cold_reset() which uses resettable API.

Also introduce resettable_cold_reset_fn() which may be used as a
replacement for qdev_reset_all_fn and qbus_reset_all_fn().

Following patches will be needed to look at legacy reset call sites
and switch to resettable api. The legacy functions will be removed
when unused.

Signed-off-by: Damien Hedde <address@hidden>
[...]>>   +void resettable_cold_reset_fn(void *opaque)
+    resettable_reset((Object *) opaque, RESET_TYPE_COLD);

Why not take a Object* argument?

This function is used to register a reset callback with
qemu_register_reset() (path 10 and 11), so we need void* to match the

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]