[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] s390x: Don't do a normal reset on the initial cpu

From: David Hildenbrand
Subject: Re: [PATCH 1/4] s390x: Don't do a normal reset on the initial cpu
Date: Fri, 22 Nov 2019 11:55:54 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1

On 22.11.19 08:52, Janosch Frank wrote:
The initiating cpu needs to be reset with an initial reset. While
doing a normal reset followed by a initial reset is not wron per-se,
the Ultravisor will only allow the correct reset to be performed.

Signed-off-by: Janosch Frank <address@hidden>
  hw/s390x/s390-virtio-ccw.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index d3edeef0ad..c1d1440272 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -348,6 +348,9 @@ static void s390_machine_reset(MachineState *machine)
      case S390_RESET_LOAD_NORMAL:
          CPU_FOREACH(t) {
+            if (t == cs) {
+                continue;
+            }
              run_on_cpu(t, s390_do_cpu_reset, RUN_ON_CPU_NULL);

Right, AFAIKS, s390_cpu_initial_reset() does a s390_cpu_reset() right no, so nothing should change.

Reviewed-by: David Hildenbrand <address@hidden>



David / dhildenb

reply via email to

[Prev in Thread] Current Thread [Next in Thread]