[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 4/6] s390x: Move clear reset

From: Janosch Frank
Subject: Re: [PATCH v4 4/6] s390x: Move clear reset
Date: Thu, 28 Nov 2019 09:35:38 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1

On 11/28/19 8:09 AM, Thomas Huth wrote:
> On 27/11/2019 18.50, Janosch Frank wrote:
>> Let's also move the clear reset function into the reset handler.
>> Signed-off-by: Janosch Frank <address@hidden>
>> ---
>>   target/s390x/cpu-qom.h |  1 +
>>   target/s390x/cpu.c     | 58 +++++++++++++-----------------------------
>>   2 files changed, 18 insertions(+), 41 deletions(-)
> I really wonder why we had so much duplicated code here before and 
> nobody dared to clean it up in all those years... Thanks for doing that now!

Looking back at my old patch series, I most often start with a cleanup
before I change or add anything...

I'd guess that QEMU hasn't seen some love for a longer time.

> Reviewed-by: Thomas Huth <address@hidden>


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]