[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 0/1] s390x: protvirt: SCLP interpretation

From: Pierre Morel
Subject: Re: [PATCH v1 0/1] s390x: protvirt: SCLP interpretation
Date: Thu, 28 Nov 2019 14:15:12 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0

On 2019-11-28 13:28, Janosch Frank wrote:
On 11/28/19 11:13 AM, Pierre Morel wrote:
A new proposition:
I think it would be wise to fork directly from handle_instruction
instead to accept per default all instructions with with secure
instruction interception code.
Just in case future firmware with older QEMU.

How ever I let three dors open.

1) This patch accepts the all B2 instructions, mostly I/O.
Some of the instructions will not work correctly for PV until patched.
This should be fixed, and will be, in a separate patch.

2) The same is true for DIAG instructions.

3) Secure notifications are separated from secure instructions and
normal instructions interception because this case is completely new.
For B2 instructions we do not have to do anything this just informative.
However, one information is of interrest, a notification that
SIGP(STOP) is sent to stop the CPUs and terminate QEMU.
Pierre, I told you this morning that I don't want this and that you
should leave this untouched until I can explain my thoughts behind the
initial patch in a f2f.
Thomas' review of your change only confirmed my concerns about this patch.

This is the wrong patch at the wrong time, which creates noise and work
for other people. Please stop and work on something else.


- you sent to me info on slack that I did not see until now, next time be sure I have acknowledged if it is important.

- You told me to dive into this patch quite abruptly, and it invested time to understand how the I/O works with PV, so sorry for the wrong time

- I see no problem with the questions from Thomas, may be you can explain this to me

- I have a lot of other things to do so I just close this thread after having answered to Thomas.

Pierre Morel (1):
   s390x: protvirt: SCLP interpretation

  hw/s390x/sclp.c         | 18 +++++++++++++
  include/hw/s390x/sclp.h |  2 ++
  target/s390x/kvm.c      | 56 ++++++++++++++++++++++++++++++++++++++++-
  3 files changed, 75 insertions(+), 1 deletion(-)

Pierre Morel
IBM Lab Boeblingen

reply via email to

[Prev in Thread] Current Thread [Next in Thread]