[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 10/13] vl: replace deprecated qbus_reset_all registration

From: Peter Maydell
Subject: Re: [PATCH v5 10/13] vl: replace deprecated qbus_reset_all registration
Date: Fri, 29 Nov 2019 19:01:45 +0000

On Fri, 18 Oct 2019 at 16:07, Damien Hedde <address@hidden> wrote:
> Replace deprecated qbus_reset_all by resettable_cold_reset_fn for
> the sysbus reset registration.
> Apart for the raspi machines, this does not impact the behavior
> because:
> + at this point resettable just call the old reset methods of devices


>   and buses in the same order than qdev/qbus.

"same order as"

> + resettable handlers registered with qemu_register_reset are
>   serialized; there is no interleaving.
> + eventual explicit calls to legacy reset API (device_reset or
>   qdev/qbus_reset) inside this reset handler will not be masked out
>   by resettable mechanism; they do not go through resettable api.
> For the raspi machines, during the sysbus reset the sd-card is not
> reset twice anymore but only once. This is consequence of switching

"a consequence"

> both sysbus reset and changing parent to resettable; it detects the
> second reset is not needed. This has no impact on the state after
> reset; the sd-card reset method only reset local state and query
> information from the block backend.

Reviewed-by: Peter Maydell <address@hidden>

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]