[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 00/14] chardev: Use QEMUChrEvent enum in IOEventHandler typed

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 00/14] chardev: Use QEMUChrEvent enum in IOEventHandler typedef
Date: Tue, 17 Dec 2019 17:50:37 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 12/17/19 5:37 PM, Philippe Mathieu-Daudé wrote:

After this chat on #qemu IRC:
13:20 <stsquad> so what is the difference between a IOReadHandler and 
13:25 <f4bug> stsquad: one is in-band and the other out-of-band?
13:26 <stsquad> f4bug: ahh yes it seems so - connect/disconnect etc...
13:27 <f4bug> see QEMUChrEvent for IOEventHandler

I thought it might be a good opportunity to make the IOEventHandler
typedef meaning more obvious, by using the QEMUChrEvent enum.

To be able to build I had to explicit a 'default' case when frontends
use a switch(event) case and do not handle all events.

Then I used a coccinelle spatch to change the various IOEventHandler.
I don't think the last patch can be split, but suggestions are welcome!



PD: I use git-publish. To avoid spamming too much, I'm using per-patch
Cc tag, after the '---' separator. This way each recipient should get
the cover and the specific patches of interests, + the last one.

Sent with: 'git publish --suppress-cc=cccmd'

While 'git-publish --verbose' show it was adding recipient from the tags:
(mbox) Adding cc: ...
(mbox) Adding cc: ...

It still sent each patch to everybody from the cover:
RCPT TO: ...
RCPT TO: ...

Maybe the list was cached in the tag and I should have use the --override-cc flag too:

  --override-cc     Ignore any profile or saved CC emails

I apologize for the no-relevant patches I spammed you with :(

Cc: "Gonglei (Arei)" <address@hidden>
Cc: "Marc-André Lureau" <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Cc: "Alex Bennée" <address@hidden>
Cc: "Philippe Mathieu-Daudé" <address@hidden>
Cc: Andrzej Zaborowski <address@hidden>
Cc: Peter Maydell <address@hidden>
Cc: "Michael S. Tsirkin" <address@hidden>
Cc: Kevin Wolf <address@hidden>
Cc: Max Reitz <address@hidden>
Cc: "Edgar E. Iglesias" <address@hidden>
Cc: Alistair Francis <address@hidden>
Cc: Antony Pavlov <address@hidden>
Cc: Igor Mitsyanko <address@hidden>
Cc: Fabien Chouteau <address@hidden>
Cc: KONRAD Frederic <address@hidden>
Cc: Peter Chubb <address@hidden>
Cc: Alberto Garcia <address@hidden>
Cc: Michael Walle <address@hidden>
Cc: Thomas Huth <address@hidden>
Cc: Joel Stanley <address@hidden>
Cc: Cornelia Huck <address@hidden>
Cc: Halil Pasic <address@hidden>
Cc: Christian Borntraeger <address@hidden>
Cc: Laurent Vivier <address@hidden>
Cc: Amit Shah <address@hidden>
Cc: Corey Minyard <address@hidden>
Cc: Paul Burton <address@hidden>
Cc: Aleksandar Rikalo <address@hidden>
Cc: Aurelien Jarno <address@hidden>
Cc: Aleksandar Markovic <address@hidden>
Cc: Palmer Dabbelt <address@hidden>
Cc: Sagar Karandikar <address@hidden>
Cc: Bastian Koppelmann <address@hidden>
Cc: Gerd Hoffmann <address@hidden>
Cc: Samuel Thibault <address@hidden>
Cc: "Dr. David Alan Gilbert" <address@hidden>
Cc: Markus Armbruster <address@hidden>
Cc: Zhang Chen <address@hidden>
Cc: Li Zhijian <address@hidden>
Cc: Jason Wang <address@hidden>
Cc: address@hidden
Cc: address@hidden
Cc: address@hidden
Cc: address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]