[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4] target/s390x/kvm: Enable adapter interruption suppression

From: Matthew Rosato
Subject: Re: [PATCH v4] target/s390x/kvm: Enable adapter interruption suppression again
Date: Tue, 21 Jan 2020 11:57:19 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0

On 1/21/20 11:33 AM, Thomas Huth wrote:
The AIS feature has been disabled late in the v2.10 development cycle since
there were some issues with migration (see commit 3f2d07b3b01ea61126b -
"s390x/ais: for 2.10 stable: disable ais facility"). We originally wanted
to enable it again for newer machine types, but apparently we forgot to do
this so far. Let's do it for the new s390-ccw-virtio-5.0 machine now.

While at it, also add a more verbose comment why we need the *_allowed()
wrappers in s390-virtio-ccw.c.

Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1756946
Reviewed-by: David Hildenbrand <address@hidden>
Tested-by: Matthew Rosato <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
  v4: Use kvm_kernel_irqchip_allowed() for avoiding problems when running
      with -machine s390-ccw-virtio,kernel_irqchip=off

  hw/s390x/s390-virtio-ccw.c         | 20 +++++++++++++++++---
  include/hw/s390x/s390-virtio-ccw.h |  3 +++
  target/s390x/kvm.c                 |  9 ++++++---
  3 files changed, 26 insertions(+), 6 deletions(-)

For the sake of completeness, re-ran a quick test on v4.  Looks good.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]