qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] cpu: Use DeviceClass reset instead of a special CPUClass res


From: Peter Maydell
Subject: Re: [PATCH] cpu: Use DeviceClass reset instead of a special CPUClass reset
Date: Tue, 3 Mar 2020 18:36:35 +0000

On Tue, 3 Mar 2020 at 18:33, Philippe Mathieu-Daudé <address@hidden> wrote:
> Nitpick: you don't need to include the bracket symbol in the diff:
>
>    @@
>    -resetfn(CPUState *cpu)
>    +resetfn(DeviceState *dev)
>     {
>
> (simply indent it with a space).

I think this was probably leftover from trying to get Coccinelle
to not rewrap the '{' onto the previous line, before I found
--smpl-spacing.

In general I don't find it terribly useful to spend a great
deal of time streamlining Coccinelle scripts -- I think they
are basically one-shot uses almost all of the time, so once
they're producing the right changes I prefer to move on.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]