qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pc-bios/s390-ccw: Generate and include dependency files in t


From: Cornelia Huck
Subject: Re: [PATCH] pc-bios/s390-ccw: Generate and include dependency files in the Makefile
Date: Wed, 1 Jul 2020 12:53:01 +0200

On Tue, 30 Jun 2020 16:29:55 +0200
Thomas Huth <thuth@redhat.com> wrote:

> The Makefile of the s390-ccw bios does not handle dependencies of the
> *.c files from the headers yet, so that you often have to run a "make
> clean" to get the build right when one of the headers has been changed.
> Let's make sure that we generate and include dependency files for all
> *.c files now to avoid this problem in the future.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  pc-bios/s390-ccw/Makefile    |  3 +++
>  pc-bios/s390-ccw/netboot.mak | 13 +++++++------
>  2 files changed, 10 insertions(+), 6 deletions(-)

My Makefile-fu is not that strong, but this looks sane to me.

Acked-by: Cornelia Huck <cohuck@redhat.com>

[I can also pick this directly, if you do not plan to send me a bios
pull req.]




reply via email to

[Prev in Thread] Current Thread [Next in Thread]