Re: [PULL SUBSYSTEM s390x 00/11] s390-ccw bios update

[no-reply]

Patchew URL: 20200702115045.6171-1-thuth@redhat.com/">https://patchew.org/QEMU/20200702115045.6171-1-thuth@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL SUBSYSTEM s390x 00/11] s390-ccw bios update
Type: series
Message-id: 20200702115045.6171-1-thuth@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20200702115045.6171-1-thuth@redhat.com -> 
patchew/20200702115045.6171-1-thuth@redhat.com
Switched to a new branch 'test'
08322ed pc-bios/s390: Update s390-ccw bios binaries with the latest changes
fa1b24c pc-bios/s390-ccw: Generate and include dependency files in the Makefile
2a10b04 pc-bios: s390x: Make u32 ptr check explicit
eabfe81 pc-bios: s390x: Use ebcdic2ascii table
a1f5d42 pc-bios: s390x: Move panic() into header and add infinite loop
11e6639 pc-bios: s390x: Use PSW masks where possible and introduce 
PSW_MASK_SHORT_ADDR
698cf8e pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64
09abe4a pc-bios: s390x: Get rid of magic offsets into the lowcore
187e4da pc-bios: s390x: Move sleep and yield to helper.h
4b2ae23 pc-bios: s390x: Consolidate timing functions into time.h
bafe452 pc-bios: s390x: cio.c cleanup and compile fix

=== OUTPUT BEGIN ===
1/11 Checking commit bafe4528bda4 (pc-bios: s390x: cio.c cleanup and compile 
fix)
2/11 Checking commit 4b2ae23f4133 (pc-bios: s390x: Consolidate timing functions 
into time.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#97: 
new file mode 100644

total: 0 errors, 1 warnings, 142 lines checked

Patch 2/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/11 Checking commit 187e4daaa561 (pc-bios: s390x: Move sleep and yield to 
helper.h)
4/11 Checking commit 09abe4ab2f1c (pc-bios: s390x: Get rid of magic offsets 
into the lowcore)
ERROR: spaces required around that ':' (ctx:VxV)
#34: FILE: pc-bios/s390-ccw/cio.h:127:
+            __u16 cssid:8;
                        ^

ERROR: spaces required around that ':' (ctx:VxV)
#35: FILE: pc-bios/s390-ccw/cio.h:128:
+            __u16 reserved:4;
                           ^

ERROR: spaces required around that ':' (ctx:VxV)
#36: FILE: pc-bios/s390-ccw/cio.h:129:
+            __u16 m:1;
                    ^

ERROR: spaces required around that ':' (ctx:VxV)
#37: FILE: pc-bios/s390-ccw/cio.h:130:
+            __u16 ssid:2;
                       ^

ERROR: spaces required around that ':' (ctx:VxV)
#38: FILE: pc-bios/s390-ccw/cio.h:131:
+            __u16 one:1;
                      ^

total: 5 errors, 0 warnings, 37 lines checked

Patch 4/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/11 Checking commit 698cf8e0b1f5 (pc-bios: s390x: Rename PSW_MASK_ZMODE to 
PSW_MASK_64)
6/11 Checking commit 11e663982839 (pc-bios: s390x: Use PSW masks where possible 
and introduce PSW_MASK_SHORT_ADDR)
7/11 Checking commit a1f5d4280c22 (pc-bios: s390x: Move panic() into header and 
add infinite loop)
8/11 Checking commit eabfe8127b88 (pc-bios: s390x: Use ebcdic2ascii table)
9/11 Checking commit 2a10b04887c5 (pc-bios: s390x: Make u32 ptr check explicit)
10/11 Checking commit fa1b24ca40d3 (pc-bios/s390-ccw: Generate and include 
dependency files in the Makefile)
11/11 Checking commit 08322ed01c42 (pc-bios/s390: Update s390-ccw bios binaries 
with the latest changes)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200702115045.6171-1-thuth@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200702115045.6171-1-thuth@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com