[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.2 1/6] pc-bios/s390-ccw/Makefile: Compile with -std=gnu
Re: [PATCH for-5.2 1/6] pc-bios/s390-ccw/Makefile: Compile with -std=gnu99, -fwrapv and -fno-common
Wed, 29 Jul 2020 10:34:34 +0200
On Tue, 28 Jul 2020 20:37:29 +0200
Thomas Huth <email@example.com> wrote:
> The main QEMU code is compiled with -std=gnu99, -fwrapv and -fno-common.
> We should use the same flags for the s390-ccw bios, too, to avoid that
> we get different behavior with different compiler versions that changed
> their default settings in the course of time (it happened at least with
> -std=... and -fno-common in the past already).
> While we're at it, also group the other flags here in a little bit nicer
> fashion: Move the two "-m" flags out of the "-f" area and specify them on
> a separate line.
> Signed-off-by: Thomas Huth <firstname.lastname@example.org>
> pc-bios/s390-ccw/Makefile | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Commonality is good :)
Acked-by: Cornelia Huck <email@example.com>