[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 17/21] target/s390x: add BQL to do_interrupt and cpu_exec_
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH v1 17/21] target/s390x: add BQL to do_interrupt and cpu_exec_interrupt |
|
Date: |
Thu, 6 Aug 2020 11:12:59 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 |
On 06/08/20 10:59, Cornelia Huck wrote:
>> bool stopped = false;
>> -
>> + bool bql = !qemu_mutex_iothread_locked();
>> + if (bql) {
>> + qemu_mutex_lock_iothread();
>> + }
> I'm not sure I like that conditional locking. Can we instead create
> __s390_cpu_do_interrupt() or so, move the meat of this function there,
> take the bql unconditionally here, and...
>
Agreed, except the usual convention would be s390_cpu_do_interrupt_locked.
Paolo