[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] tests/acceptance: verify s390x device detection

From: Wainer dos Santos Moschetta
Subject: Re: [PATCH 2/3] tests/acceptance: verify s390x device detection
Date: Fri, 4 Dec 2020 10:47:34 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0

On 11/30/20 3:02 PM, Cornelia Huck wrote:
The kernel/initrd combination does not provide the virtio-net
driver; therefore, simply check whether the presented device type
is indeed virtio-net for the two virtio-net-{ccw,pci} devices.

Signed-off-by: Cornelia Huck <cohuck@redhat.com>
  tests/acceptance/machine_s390_ccw_virtio.py | 11 +++++++++++
  1 file changed, 11 insertions(+)

diff --git a/tests/acceptance/machine_s390_ccw_virtio.py 
index 683b6e0dac2e..e203ee304264 100644
--- a/tests/acceptance/machine_s390_ccw_virtio.py
+++ b/tests/acceptance/machine_s390_ccw_virtio.py
@@ -80,3 +80,14 @@ class S390CCWVirtioMachine(Test):
+        # verify that we indeed have virtio-net devices (without having the
+        # virtio-net driver handy)
+        exec_command_and_wait_for_pattern(self,
+                                          'cat 
+                                          '3832/01')
+        exec_command_and_wait_for_pattern(self,
+                                          'cat 
+                                          '0x1af4')
+        exec_command_and_wait_for_pattern(self,
+                                          'cat 
+                                          '0x0001')

Here I think it's ok to do...

        'cat /sys/bus/ccw/devices/0.1.1111/cutype',

... so checkpatch is happy, everybody is happy.

Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]