[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translatio

From: Richard Henderson
Subject: Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translation
Date: Wed, 14 Apr 2021 12:43:04 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 4/14/21 11:03 AM, Max Filippov wrote:
On Wed, Apr 14, 2021 at 9:51 AM Ilya Leoshkevich <iii@linux.ibm.com> wrote:
On Wed, 2021-04-14 at 16:48 +0200, David Hildenbrand wrote:
Did you double-check the xtensa issue?

Oh, I'm sorry, I completely forgot about that one. I just ran the
test locally, and apparently it fails because of this new assert, so
I'll have to write the 4th patch now. Thanks!

Just curious, what xtensa issue?

Returning from xtensa_tr_translate_insn with tb->size == 0.

Basically, dc->base.pc_next needs to be incremented even for illegal instructions, preferably by the number of bytes consumed while determining that the insn is illegal.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]