[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/8] Acceptance tests: do not try to reuse packages from the

From: Wainer dos Santos Moschetta
Subject: Re: [PATCH 2/8] Acceptance tests: do not try to reuse packages from the system
Date: Mon, 19 Apr 2021 15:14:58 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 4/15/21 6:51 PM, Cleber Rosa wrote:
The premise behind the original behavior is that it would save people
from downloading Avocado (and other dependencies) if already installed
on the system.  To be honest, I think it's extremely rare that the
same versions described as dependencies will be available on most
systems.  But, the biggest motivations here are that:

  1) Hacking on QEMU in the same system used to develop Avocado leads
     to confusion with regards to the exact bits that are being used;

  2) Not reusing Python packages from system wide installations gives
     extra assurance that the same behavior will be seen from tests run
     on different machines;

With regards to downloads, pip already caches the downloaded wheels
and tarballs under ~/.cache/pip, so there should not be more than
one download even if the venv is destroyed and recreated.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
  tests/Makefile.include | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>

diff --git a/tests/Makefile.include b/tests/Makefile.include
index 8f220e15d1..63477c8b4b 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -96,7 +96,7 @@ AVOCADO_TAGS=$(patsubst %-softmmu,-t arch:%, $(filter 
        $(call quiet-command, \
-            $(PYTHON) -m venv --system-site-packages $@, \
+            $(PYTHON) -m venv $@, \
              VENV, $@)
        $(call quiet-command, \
              $(TESTS_VENV_DIR)/bin/python -m pip -q install -r 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]