[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/8] tests/acceptance/linux_ssh_mips_malta.py: drop identical

From: Wainer dos Santos Moschetta
Subject: Re: [PATCH 3/8] tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp
Date: Mon, 19 Apr 2021 15:25:21 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 4/16/21 2:46 PM, Philippe Mathieu-Daudé wrote:
On 4/16/21 5:43 PM, Cleber Rosa wrote:
On Fri, Apr 16, 2021 at 07:26:05AM +0200, Philippe Mathieu-Daudé wrote:
On 4/15/21 11:51 PM, Cleber Rosa wrote:
These tests' setUp do not do anything beyong what their base class do.
And while they do decorate the setUp() we can decorate the classes
instead, so no functionality is lost here.
This is what I did first when adding this test, but it was not working,
so I had to duplicate it to each method. Did something change so now
this is possible?

It did, but quite a while ago:

OK, the test is older. Do you mind adding a comment?

"Since Avocado 76.0 we can decorate setUp() directly, ..."


Also you may want to adjust VirtiofsSubmountsTest.setUp() in tests/acceptance/virtiofs_submounts.py as well.

- Wainer

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

It could have been updated much earlier, but, better late than never.
Sure :)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]