[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/8] tests/acceptance/cpu_queries.py: use the proper logging

From: Wainer dos Santos Moschetta
Subject: Re: [PATCH 5/8] tests/acceptance/cpu_queries.py: use the proper logging channels
Date: Mon, 19 Apr 2021 15:56:31 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0


On 4/15/21 6:51 PM, Cleber Rosa wrote:
The test contains methods for the proper log of test related
information.  Let's use that and remove the print and the unused
logging import.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
  tests/acceptance/cpu_queries.py | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tests/acceptance/cpu_queries.py b/tests/acceptance/cpu_queries.py
index 293dccb89a..cc9e380cc7 100644
--- a/tests/acceptance/cpu_queries.py
+++ b/tests/acceptance/cpu_queries.py
@@ -8,8 +8,6 @@
  # This work is licensed under the terms of the GNU GPL, version 2 or
  # later.  See the COPYING file in the top-level directory.
-import logging
  from avocado_qemu import Test
class QueryCPUModelExpansion(Test):
@@ -27,7 +25,7 @@ def test(self):
cpus = self.vm.command('query-cpu-definitions')
          for c in cpus:
-            print(repr(c))
+            self.log.info("Checking CPU: %s", c)
              self.assertNotIn('', c['unavailable-features'], c['name'])
for c in cpus:

While you are here, maybe merge the two `for c in cpus` loops? :D


Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]