[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] linux-user/s390x: Clean up signal.c

From: David Hildenbrand
Subject: Re: [PATCH 2/3] linux-user/s390x: Clean up signal.c
Date: Wed, 28 Apr 2021 15:56:08 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 28.04.21 05:32, Richard Henderson wrote:
The "save" routines from the kernel, which are currently
commented out, are unnecessary in qemu.  We can copy from
env where the kernel needs special instructions.

Drop the return value from restore_sigregs, as it cannot fail.
Use __get_user return as input to trace, so that we properly
bswap the value for the host.

Reorder the function bodies to correspond to the kernel source.
Fix the use of host addresses where guest addresses are needed.
Drop the use of PSW_ADDR_AMODE, since we only support 64-bit.
Set psw.mask properly for the signal handler.
Use tswap_sigset in setup_rt_frame.

This would be a lot easier to review if this would be split up into individual patches.


David / dhildenb

reply via email to

[Prev in Thread] Current Thread [Next in Thread]