[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 02/23] cpu: Restrict target cpu_do_transaction_failed() ha

From: Richard Henderson
Subject: Re: [PATCH v7 02/23] cpu: Restrict target cpu_do_transaction_failed() handlers to sysemu
Date: Tue, 25 May 2021 19:12:49 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 5/17/21 3:51 AM, Philippe Mathieu-Daudé wrote:
In commit cbc183d2d9f ("cpu: move cc->transaction_failed to tcg_ops")
we restricted the do_transaction_failed() handler to the sysemu part
of TCGCPUOps, but forgot to restrict the target specific declarations.

Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
  target/arm/internals.h |  2 ++
  target/m68k/cpu.h      |  2 ++
  target/riscv/cpu.h     | 10 +++++-----
  target/xtensa/cpu.h    |  8 ++++----
  4 files changed, 13 insertions(+), 9 deletions(-)

What do the extra ifdefs buy us? Surely the fact that the symbol is not present in the user-only, and would produce link errors if used, is sufficient?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]