[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 02/23] cpu: Restrict target cpu_do_transaction_failed() ha

From: Richard Henderson
Subject: Re: [PATCH v7 02/23] cpu: Restrict target cpu_do_transaction_failed() handlers to sysemu
Date: Wed, 26 May 2021 10:47:30 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 5/26/21 10:22 AM, Philippe Mathieu-Daudé wrote:
What do the extra ifdefs buy us? Surely the fact that the symbol is not
present in the user-only, and would produce link errors if used, is

Last month on another series you told me we should declare prototypes
that can't be used :) However I agree we want *less* #ifdef'ry, not

Should or shouldn't?

Anyway, I don't think any of these declarations belong in cpu.h. There's no reason for any external user to reference them, as they ought to be using the hw/core/ cpu_* functions.

In an ideal world, we'd move them into some target/foo/sysemu/internal.h or something, which would involve no ifdefs and still give you the isolation.

But for the bulk of the targets, I think it's just easier to leave them alone.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]