[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1] s390x/tcg: fix and optimize SPX (SET PREFIX)

From: David Hildenbrand
Subject: Re: [PATCH v1] s390x/tcg: fix and optimize SPX (SET PREFIX)
Date: Fri, 6 Aug 2021 13:30:49 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 06.08.21 13:17, Cornelia Huck wrote:
On Thu, Aug 05 2021, David Hildenbrand <david@redhat.com> wrote:

We not only invalidate the translation of the range 0x0-0x2000, we also
invalidate the translation of the new prefix range and the translation
of the old prefix range -- because real2abs would return different
results for all of these ranges when changing the prefix location.

This fixes the kvm-unit-tests "edat" test that just hangs before this
patch because we end up clearing the new prefix area instead of the old
prefix area.

While at it, let's not do anything in case the prefix doesn't change.

Cc: Richard Henderson <richard.henderson@linaro.org>
Cc: David Hildenbrand <david@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>
Cc: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: qemu-s390x@nongnu.org
Signed-off-by: David Hildenbrand <david@redhat.com>
  target/s390x/tcg/misc_helper.c | 15 ++++++++++++++-
  1 file changed, 14 insertions(+), 1 deletion(-)

Is this still -rc material? Especially as we are late in the -rc cycle

It's been broken forever, this can wait I guess.


David / dhildenb

reply via email to

[Prev in Thread] Current Thread [Next in Thread]