qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 22/30] target/ppc: Simplify has_work() handlers


From: Richard Henderson
Subject: Re: [PATCH v3 22/30] target/ppc: Simplify has_work() handlers
Date: Fri, 3 Sep 2021 22:43:03 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
The common ppc_cpu_has_work() handler already checks for cs->halted,
so we can simplify all callees.

Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
---
  target/ppc/cpu_init.c | 294 ++++++++++++++++++++----------------------
  1 file changed, 138 insertions(+), 156 deletions(-)

Well, I'm not actually a fan of this; I'd rather the outer function merely dispatch here, or preferably arrange to arrive here to begin.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]