[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 13/13] hw/s390x/s390-skeys: lazy storage key enablement un

From: Thomas Huth
Subject: Re: [PATCH v3 13/13] hw/s390x/s390-skeys: lazy storage key enablement under TCG
Date: Mon, 6 Sep 2021 12:14:50 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0

On 03/09/2021 17.55, David Hildenbrand wrote:
Let's enable storage keys lazily under TCG, just as we do under KVM.
Only fairly old Linux versions actually make use of storage keys, so it
can be kind of wasteful to allocate quite some memory and track
changes and references if nobody cares.

We have to make sure to flush the TLB when enabling storage keys after
the VM was already running: otherwise it might happen that we don't
catch references or modifications afterwards.

Add proper documentation to all callbacks.

The kvm-unit-tests skey tests keeps on working with this change.

Signed-off-by: David Hildenbrand <david@redhat.com>
  hw/s390x/s390-skeys.c           | 65 ++++++++++++++++++++++++++-------
  include/hw/s390x/storage-keys.h | 63 ++++++++++++++++++++++++++++++++
  target/s390x/mmu_helper.c       |  8 ++++
  target/s390x/tcg/mem_helper.c   |  9 +++++
  4 files changed, 131 insertions(+), 14 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]